Skip to content

Add use_proxy argument#255

Merged
petoju merged 3 commits intopetoju:masterfrom
mnival:use_proxy
Nov 23, 2025
Merged

Add use_proxy argument#255
petoju merged 3 commits intopetoju:masterfrom
mnival:use_proxy

Conversation

@mnival
Copy link
Contributor

@mnival mnival commented Oct 17, 2025

Hello,
Option to solve this issue: #232

Copy link
Owner

@petoju petoju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Owner

@petoju petoju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, don't you want to implement NO_PROXY as mentioned in the ticket?

@mnival
Copy link
Contributor Author

mnival commented Oct 17, 2025

Hello,
Using NO_PROXY is more complex, but I can rewrite it if you prefer. Since we only define the host in the provider config, I think that’s enough.

@petoju
Copy link
Owner

petoju commented Oct 17, 2025

@mnival that would be better - it's because this is too specific to one provider and one would have to manually change it if it was needed.

@mnival
Copy link
Contributor Author

mnival commented Nov 22, 2025

Hello @petoju,
Sorry for the delay I review to use the standard no_proxy and use the curl syntax
Thank you

@petoju petoju merged commit 5b7382e into petoju:master Nov 23, 2025
15 checks passed
@petoju
Copy link
Owner

petoju commented Nov 23, 2025

Thanks @mnival ! I merged it and released it as v3.0.86.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants