Change boxsize into rectangular bounds #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terahlunah
force-pushed
the
use_rectangular_bounds
branch
from
cd2ac9c to
ba54b74
Compare
terahlunah
force-pushed
the
use_rectangular_bounds
branch
from
ba54b74 to
034b12d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow users to specify 2 different sizes for the
bounds(x and y) instead of a squareboxsize.While it is simpler than the proposed implementation in #2, the results are the same as one can simply translate all the output points to rescale the domain.
This also fix the last issue reported here #4 (comment)