Open
Conversation
At the moment, the generator is always TapoRequest, but this format allows different generators to be added to reflect different API protocols.
TapoRequestH200 generates requests in a format understood by H200 hubs (e.g. generally camel case rather than snake case). Some functions not immediately supported (WIP) Some tweaks required elsewhere where code assumes particular API format.
Also better error handling
Draws heavily on the pytapo implementation. WIP: - No support for on-hub components (alarms, etc) - Inefficient finding of child components Also, tweak previous commit such that request generator is determined by the protocol itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello. I know H200 Hub support is down as WIP anyway, but I had some free time so I thought I'd give it a go. This version isn't perfect, but it did allow me to add a variety of sensors to my HomeAssistant dashboards, which I thought was a good step forward and maybe a base to build upon.
EDIT: Ah, just seen you did make some progress on this yourself along similar lines - hope the below is helpful in helping you get it across the line anyway - you can just take what you need. Not sure why I didn't check the list of PRs first, would probably have been more helpful.