Introduce new core/tabs-menu-item block#14
Merged
sethrubenstein merged 4 commits intofeat/core-tabs-restructurefrom Jan 13, 2026
Merged
Introduce new core/tabs-menu-item block#14sethrubenstein merged 4 commits intofeat/core-tabs-restructurefrom
sethrubenstein merged 4 commits intofeat/core-tabs-restructurefrom
Conversation
…der hack we use for templating blocks. *May rename the block to tabs-menu-item-template
…nterior element of tabs-menu
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 3.07 MB ℹ️ View Unchanged
|
sethrubenstein
added a commit
that referenced
this pull request
Jan 24, 2026
* New, reworked structure and editing * Refactoring the entire tabs experience, rough right now, should have this cleaned up by end of week. * Greater granular flex styling, need to go back in and cleanup old styles * Full border styles for menu items * Style tweaks * Enhance tab functionality by updating the AddTabToolbarControl to manage tabs-menu selection and active tab index. Implement auto-edit mode for newly added tabs in the TabsMenu edit component. * Allow renaming of tab blocks, leaving note in deprecation upgrade to remove later * Style and dev cleanup * Default layouts for tabs-menu and keyboard handling * Tweaks * PHPCS cleanup * Dimensions block.json supports, correct format * Adding shadow support * Cleanup * Increased performance, move client side and server side tabs list generation all into context. * Cleanup * Cleanup on styles and blockgap * Lets back off on blockspacing for tabs-menu for now * Introduce new core/tabs-menu-item block (#14) * New block/core tabs menu item (#16) * Introducing new core/tabs-menu-item block, utilizes blockcontextprovider hack we use for templating blocks. *May rename the block to tabs-menu-item-template * Trying to get this working as I'd like * Introducing core/tabs-menu-item, a templating block for styling the interior element of tabs-menu * Style cleanup * Block cleanup for MVP * Add text align to tabs-menu-item * Now tabs-menu interior items can be styled using dimensions controls in tabs-menu * Cleanup * Remove refactor artifact * Cleanup and initializing new tab with a proper label * Tab removal button - Add "Remove Tab" toolbar button to tabs block - Code cleanup * Clearer labels on block toolbar buttons * Cleaning up tabs id, utilizing anchor instead of a custom attribute, injecting tabs id dynamically if none present early in core/tabs context. * new add tab controls per some internal prc user testing with editors * Leaving the add tab in place in tabs-menu-item, pulling from tabs-menu extra appender... for now * Cleanup, align with labels like core/accordion * Move add and remove tab into segmented block toolbar group * Sensible defaults for border on tabs-menu * Resolve phpcs issue * Cleanup on style * Introduce custom controls for moving tab * remove unused tabs styles, get rid of opacity on styles, simplify styles further, enhance block example. * Cleanup on block mover * Resolve some oustanding linting issues * Linting error resolution * Resolving scss linting issue * Update core blocks documentation to reflect changes in supported features for tabs and tab panels, including color and typography attributes. Hoping this resolves final PR checks. Co-authored-by: sethrubenstein <smrubenstein@git.wordpress.org> Co-authored-by: mikachan <mikachan@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.