Skip to content

Add shader precision #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmnsgn wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add shader precision #60

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34f24c3
Add shader precision
dmnsgn Jan 13, 2019
485a4c1
Merge branch 'master' of github.com:pex-gl/pex-context into precision
dmnsgn Mar 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ function createContext(opts) {
let gl = null

const defaultOpts = {
pixelRatio: 1
pixelRatio: 1,
precision: 'highp'
}

opts = Object.assign({}, defaultOpts, opts)
Expand Down Expand Up @@ -297,6 +298,28 @@ function createContext(opts) {
capabilities.maxColorAttachments = gl.getParameter('MAX_COLOR_ATTACHMENTS')
}

function getMaxPrecision(precision = 'highp') {
Copy link
Member

@vorg vorg Jan 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getMaxPrecision is one of a kind API. More in the PR comments

if (precision === "highp") {
if (
gl.getShaderPrecisionFormat(gl.VERTEX_SHADER, gl.HIGH_FLOAT).precision > 0 &&
gl.getShaderPrecisionFormat(gl.FRAGMENT_SHADER, gl.HIGH_FLOAT).precision > 0
) {
return "highp";
}
precision = "mediump";
}
if (precision === "mediump") {
if (
gl.getShaderPrecisionFormat(gl.VERTEX_SHADER, gl.MEDIUM_FLOAT).precision > 0 &&
gl.getShaderPrecisionFormat(gl.FRAGMENT_SHADER, gl.MEDIUM_FLOAT).precision > 0
) {
return "mediump";
}
}
return "lowp";
}
capabilities.maxPrecision = getMaxPrecision(opts.precision)

log('capabilities', capabilities)

Object.assign(ctx, {
Expand Down Expand Up @@ -328,7 +351,8 @@ function createContext(opts) {
}
return str
},
set: function(opts) {
getMaxPrecision,
set: function (opts) {
assert(isBrowser, 'changing resolution is not supported in Plask')
if (opts.pixelRatio) {
this.updatePixelRatio = Math.min(
Expand Down