Code Quality Fixes

.gitignore

@@ -2,6 +2,7 @@
 /node_modules/
 /vendor/
 .DS_Store
+.idea
 _build
 composer.lock
 package-lock.json

404.php

@@ -25,7 +25,17 @@
 					<div class="widget">
 						<h2 class="widgettitle"><?php _e( 'Most Used Categories', 'autonomie' ); ?></h2>
 						<ul>
-						<?php wp_list_categories( array( 'orderby' => 'count', 'order' => 'DESC', 'show_count' => 1, 'title_li' => '', 'number' => 10 ) ); ?>
+						<?php
+						wp_list_categories(
+							array(
+								'orderby' => 'count',
+								'order' => 'DESC',
+								'show_count' => 1,
+								'title_li' => '',
+								'number' => 10,
+							)
+						);
+						?>
 						</ul>
 					</div>
 
@@ -42,4 +52,5 @@
 
 		</main><!-- #content -->
 
-<?php get_footer(); ?>
+<?php
+get_footer();

500.php

@@ -23,4 +23,5 @@
 
 		</main><!-- #content -->
 
-<?php get_footer(); ?>
+<?php
+get_footer();

archive.php

@@ -51,4 +51,5 @@
 
 			</main><!-- #content -->
 
-<?php get_footer(); ?>
+<?php
+get_footer();

comments.php

@@ -31,7 +31,16 @@
 		<h2 id="comments-title">
 			<?php
 				printf(
-					_n( 'One thought on &ldquo;%2$s&rdquo;', '%1$s thoughts on &ldquo;%2$s&rdquo;', get_comments_number(), 'autonomie' ),
+					/* translators:
+					%1$s: number of comments, mind to add this if your language uses singular for more than just n=1
+					%2$s: post title
+					*/
+					_n(
+						'One thought on &ldquo;%2$s&rdquo;', // phpcs:ignore WordPress.WP.I18n.MissingSingularPlaceholder -- Translator instructions added.
+						'%1$s thoughts on &ldquo;%2$s&rdquo;',
+						get_comments_number(),
+						'autonomie'
+					),
 					number_format_i18n( get_comments_number() ),
 					'<span>' . get_the_title() . '</span>'
 				);
@@ -54,7 +63,12 @@
 				 * define autonomie_comment() and that will be used instead.
 				 * See autonomie_comment() in autonomie/functions.php for more.
 				 */
-				wp_list_comments( array( 'callback' => 'autonomie_comment', 'format' => '' ) );
+				wp_list_comments(
+					array(
+						'callback' => 'autonomie_comment',
+						'format' => '',
+					)
+				);
 			?>
 		</ol>
 

composer.json

@@ -2,7 +2,7 @@
 	"name": "pfefferle/wordpress-autonomie",
 	"description": "Pure Zen",
 	"require": {
-		"php": ">=5.6.0",
+		"php": ">=7.4.0",
 		"composer/installers": "~2.2"
 	},
 	"type": "wordpress-theme",
@@ -15,5 +15,10 @@
 	],
 	"extra": {
 		"installer-name": "autonomie"
+	},
+	"config": {
+		"allow-plugins": {
+			"composer/installers": true
+		}
 	}
 }

footer.php

@@ -28,7 +28,14 @@
 
 		<div id="site-generator">
 			<?php do_action( 'autonomie_credits' ); ?>
-			<?php printf( __( 'This site is powered by %1$s and styled with the %2$s theme', 'autonomie' ), '<a href="https://wordpress.org/" rel="generator">WordPress</a>', '<a href="https://notiz.blog/projects/autonomie/">Autonomie</a>' ); ?>
+			<?php
+			printf(
+				// translators: %1$s: Link to WordPress, %2$s: Link to Autonomie theme.
+				__( 'This site is powered by %1$s and styled with the %2$s theme', 'autonomie' ),
+				'<a href="https://wordpress.org/" rel="generator">WordPress</a>',
+				'<a href="https://notiz.blog/projects/autonomie/">Autonomie</a>'
+			);
+			?>
 		</div>
 	</footer><!-- #colophon -->
 </div><!-- #page -->

functions.php

@@ -470,7 +470,7 @@ function autonomie_comment( $comment, $args, $depth ) {
 		$GLOBALS['comment'] = $comment;
 		?>
 		<li <?php comment_class(); ?> id="li-comment-<?php comment_ID(); ?>">
-			<article id="comment-<?php comment_ID(); ?>" class="comment <?php $comment->comment_type; ?>" itemprop="comment" itemscope itemtype="https://schema.org/Comment">
+			<article id="comment-<?php comment_ID(); ?>" class="comment <?php echo $comment->comment_type; ?>" itemprop="comment" itemscope itemtype="https://schema.org/Comment">
 				<div class="edit-link"><?php edit_comment_link( __( 'Edit', 'autonomie' ), ' ' ); ?></div>
 				<footer class="comment-meta commentmetadata">
 					<address class="comment-author p-author author vcard hcard h-card" itemprop="creator" itemscope itemtype="https://schema.org/Person">
@@ -513,42 +513,42 @@ function autonomie_comment( $comment, $args, $depth ) {
 /**
  * All template functions
  */
-require( get_template_directory() . '/includes/template-functions.php' );
+require get_template_directory() . '/includes/template-functions.php';
 
 /**
  * Widget handling
  */
-require( get_template_directory() . '/includes/widgets.php' );
+require get_template_directory() . '/includes/widgets.php';
 
 /**
  * Adds the featured image functionality
  */
-require( get_template_directory() . '/includes/featured-image.php' );
+require get_template_directory() . '/includes/featured-image.php';
 
 /**
  * All customizer functions
  */
-require( get_template_directory() . '/includes/customizer.php' );
+require get_template_directory() . '/includes/customizer.php';
 
 /**
  * Adds some awesome websemantics like microformats(2) and microdata
  */
-require( get_template_directory() . '/includes/semantics.php' );
+require get_template_directory() . '/includes/semantics.php';
 
 /**
  * Add Webactions support
  */
-require( get_template_directory() . '/includes/webactions.php' );
+require get_template_directory() . '/includes/webactions.php';
 
 /**
  * Adds back compat handling for older WP versions
  */
-require( get_template_directory() . '/includes/compat.php' );
+require get_template_directory() . '/includes/compat.php';
 
 /**
  * Feed extensions
  */
-require( get_template_directory() . '/includes/feed.php' );
+require get_template_directory() . '/includes/feed.php';
 
 /**
  * Compatibility with other plugins, mostly IndieWeb related
@@ -559,15 +559,15 @@ function autonomie_comment( $comment, $args, $depth ) {
 	 * Adds Indieweb Syndcation Links
 	 * if github.com/dshanske/syndication-links is activated
 	 */
-	require( get_template_directory() . '/integrations/syndication-links.php' );
+	require get_template_directory() . '/integrations/syndication-links.php';
 }
 
 if ( class_exists( 'Post_Kinds_Plugin' ) ) {
-	require( get_template_directory() . '/integrations/post-kinds.php' );
+	require get_template_directory() . '/integrations/post-kinds.php';
 }
 
 if ( class_exists( '\Activitypub\Activitypub' ) ) {
-	require( get_template_directory() . '/integrations/activitypub.php' );
+	require get_template_directory() . '/integrations/activitypub.php';
 }
 
 /**

header.php

@@ -12,8 +12,8 @@
 <head>
 	<meta charset="<?php bloginfo( 'charset' ); ?>" />
 	<meta name="viewport" content="width=device-width, initial-scale=1" />
-	<link rel="profile" href="http://microformats.org/profile/specs" />
-	<link rel="profile" href="http://microformats.org/profile/hatom" />
+	<link rel="profile" href="https://microformats.org/profile/specs" />
+	<link rel="profile" href="https://microformats.org/profile/hatom" />
 
 	<?php wp_head(); ?>
 </head>

image.php

@@ -10,7 +10,10 @@
 
 			<main id="primary" <?php autonomie_main_class(); ?><?php autonomie_semantics( 'main' ); ?>>
 
-			<?php while ( have_posts() ) : the_post(); ?>
+			<?php
+			while ( have_posts() ) :
+				the_post();
+				?>
 
 				<article id="post-<?php the_ID(); ?>" <?php post_class(); ?>itemscope itemtype="https://schema.org/ImageObject">
 					<?php get_template_part( 'template-parts/entry-header' ); ?>
@@ -24,13 +27,24 @@
 								 * Grab the IDs of all the image attachments in a gallery so we can get the URL of the next adjacent image in a gallery,
 								 * or the first image (if we're looking at the last image in a gallery), or, in a gallery of one, just the link to that image file
 								 */
-								$attachments = array_values( get_children( array( 'post_parent' => $post->post_parent, 'post_status' => 'inherit', 'post_type' => 'attachment', 'post_mime_type' => 'image', 'order' => 'ASC', 'orderby' => 'menu_order ID' ) ) );
+								$attachments = array_values(
+									get_children(
+										array(
+											'post_parent' => $post->post_parent,
+											'post_status' => 'inherit',
+											'post_type' => 'attachment',
+											'post_mime_type' => 'image',
+											'order' => 'ASC',
+											'orderby' => 'menu_order ID',
+										)
+									)
+								);
 								foreach ( $attachments as $k => $attachment ) {
 									if ( $attachment->ID == $post->ID ) {
 										break;
 									}
 								}
-								$k++;
+								++$k;
 								// If there is more than 1 attachment in a gallery
 								if ( count( $attachments ) > 1 ) {
 									if ( isset( $attachments[ $k ] ) ) {
@@ -46,10 +60,12 @@
 								}
 								?>
 
-								<a href="<?php echo $next_attachment_url; ?>" title="<?php echo esc_attr( get_the_title() ); ?>" rel="attachment"><?php
-								$attachment_size = apply_filters( 'autonomie_attachment_size', 1200 );
-								echo wp_get_attachment_image( $post->ID, array( $attachment_size, $attachment_size ), null, array( 'itemprop' => 'image contentURL' ) ); // filterable image width with, essentially, no limit for image height.
-								?></a>
+								<a href="<?php echo $next_attachment_url; ?>" title="<?php echo esc_attr( get_the_title() ); ?>" rel="attachment">
+													<?php
+													$attachment_size = apply_filters( 'autonomie_attachment_size', 1200 );
+													echo wp_get_attachment_image( $post->ID, array( $attachment_size, $attachment_size ), null, array( 'itemprop' => 'image contentURL' ) ); // filterable image width with, essentially, no limit for image height.
+													?>
+								</a>
 
 								<?php if ( ! empty( $post->post_excerpt ) ) : ?>
 								<figcaption class="entry-caption">
@@ -60,7 +76,14 @@
 						</div><!-- .entry-attachment -->
 
 						<?php the_content(); ?>
-						<?php wp_link_pages( array( 'before' => '<div class="page-link">' . __( 'Pages:', 'autonomie' ), 'after' => '</div>' ) ); ?>
+						<?php
+						wp_link_pages(
+							array(
+								'before' => '<div class="page-link">' . __( 'Pages:', 'autonomie' ),
+								'after' => '</div>',
+							)
+						);
+						?>
 					</div><!-- .entry-content -->
 
 					<?php get_template_part( 'template-parts/entry-footer' ); ?>
@@ -72,4 +95,5 @@
 
 			</main><!-- #content -->
 
-<?php get_footer(); ?>
+<?php
+get_footer();

includes/compat.php

@@ -19,8 +19,8 @@
 /**
  * Adds the new  input types to the comment-form
  *
- * @param string $form
- * @return string
+ * @param array $fields The comment form fields.
+ * @return array
  */
 function autonomie_comment_autocomplete( $fields ) {
 	$fields['author'] = preg_replace( '/<input/', '<input autocomplete="nickname name" enterkeyhint="next" ', $fields['author'] );
@@ -64,9 +64,11 @@ function autonomie_query_format_standard( $query ) {
 			}
 			$query->is_tax = null;
 
-			unset( $query->query_vars['post_format'] );
-			unset( $query->query_vars['taxonomy'] );
-			unset( $query->query_vars['term'] );
+			unset(
+				$query->query_vars['post_format'],
+				$query->query_vars['taxonomy'],
+				$query->query_vars['term']
+			);
 
 			$query->set(
 				'tax_query',
@@ -103,7 +105,7 @@ function autonomie_add_lazy_loading( $content ) {
 
 add_filter(
 	'wp_lazy_loading_enabled',
-	function( $default, $tag_name, $context ) {
+	function ( $default, $tag_name, $context ) { // phpcs:ignore Universal.NamingConventions.NoReservedKeywordParameterNames.defaultFound
 		if ( 'the_content' === $context ) {
 			return false;
 		}

includes/customizer.php

@@ -10,7 +10,7 @@ function autonomie_customize_register( $wp_customize ) {
 		'autonomie_settings_section',
 		array(
 			'title' => __( 'Advanced Settings', 'autonomie' ),
-			'description' => __( 'Enable/Disable some advanced Autonomie features.', 'autonomie' ), //Descriptive tooltip
+			'description' => __( 'Enable/Disable some advanced Autonomie features.', 'autonomie' ), //Descriptive tooltip.
 			'priority' => 35,
 		)
 	);

includes/featured-image.php

@@ -104,29 +104,31 @@ function autonomie_featured_image_meta( $content, $post_id ) {
  * Safe the Post Covers
  *
  * @param int $post_id The ID of the post being saved.
+ *
+ * @return void
  */
 function autonomie_save_post( $post_id ) {
 	// if this is an autosave, our form has not been submitted, so we don't want to do anything.
 	if ( defined( 'DOING_AUTOSAVE' ) && DOING_AUTOSAVE ) {
-		return $post_id;
+		return;
 	}
 
 	if ( ! array_key_exists( 'full_width_featured_image', $_POST ) ) {
-		return $post_id;
+		return;
 	}
 
 	if ( ! array_key_exists( 'post_type', $_POST ) ) {
-		return $post_id;
+		return;
 	}
 
 	// check the user's permissions.
 	if ( 'page' === $_POST['post_type'] ) {
 		if ( ! current_user_can( 'edit_page', $post_id ) ) {
-			return $post_id;
+			return;
 		}
 	} else {
 		if ( ! current_user_can( 'edit_post', $post_id ) ) {
-			return $post_id;
+			return;
 		}
 	}
 
@@ -148,14 +150,14 @@ function autonomie_save_post( $post_id ) {
  * or none of the above conditions are true.
  */
 function autonomie_has_full_width_featured_image() {
-	// If this isn't a Single post type or we don't have a Featured Image set
+	// If this isn't a Single post type, or we don't have a Featured Image set.
 	if ( ! ( is_single() || is_page() ) || ! has_post_thumbnail() ) {
 		return false;
 	}
 
 	$full_width_featured_image = get_post_meta( get_the_ID(), 'full_width_featured_image', true );
 
-	// If Use featured image as Post Cover has been checked in the Featured Image meta box, return true.
+	// If "Use featured image as Post Cover" has been checked in the Featured Image meta box, return true.
 	if ( '1' === $full_width_featured_image ) {
 		return true;
 	}