Remove Webmention Dependence on Pings

[dshanske]

This removes webmention receiving being dependent on pings_open. It does allow for checking the presence of a webmentions_closed meta key to close webmentions. If this approach is validated, will move to figure out a UI for this.

For the sending, it moves from using the pung URLs property within the post object to a new temporary storage that will just store what was sent last time, compare it to what is being send this time, and use that to send deleted webmentions.

[dshanske]

@pfefferle Where are we on this one?

[pfefferle]

get_pung will now be updated, but not taken into care for Webmentions, so there might still be the possibility that we send Webmentions for URLs that were already pinged?!?

[pfefferle]

I agree that we should not care about the pingback settings, but why change the get_pung code?

[dshanske]

I like that addition. If we're happy with this... then a future addition can add the UI to close Webmentions.. but it assumes activating the plugin means you want them

[pfefferle]

@dshanske this last commit adds settings to the block editor to disable Webmentions for a post.

[pfefferle]

should it be also possible to deactivate outgoing Webmentions?

[dshanske]

should it be also possible to deactivate outgoing Webmentions?

We had someone who wanted to do that on a per post basis... but I'm not sure it is a desired feature by many

[pfefferle]

Ok, then we do that in a different PR!

[dshanske]

I thought they got removed on purpose. Must have misread

[pfefferle]

The Grunt dependencies are no longer needed... I need the other deps to work on the block-editor integration...

[dshanske]

That's my fault... confused the two

[pfefferle]

No problem :)

[dshanske]

Is this ready for merge, @pfefferle ? Want to see about some other fixes for a minor release.

[pfefferle]

I think we should add some tests, to ensure that everything still works after the merge!?!

[dshanske]

I'll see about getting some in and doing a dual platform check.