Disable outgoing Webmentions #525
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new option to disable outgoing Webmentions while updating the existing incoming Webmentions option. The changes include updating the editor plugin to provide both incoming and outgoing controls, adjusting the meta key handling in PHP, and augmenting the block registration to support the new meta field.
- Updated editor plugin UI and asset bundle for handling two webmention options.
- Modified server-side meta checks and post meta registration to account for outgoing webmentions.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/editor-plugin/plugin.js | Updated CheckboxControl labels and added a new checkbox for outgoing. |
| includes/class-webmention.php | Extended meta check to include outgoing webmention disable key. |
| includes/class-block.php | Registered new meta for outgoing webmentions. |
| build/editor-plugin/plugin.js | Updated bundled plugin code to integrate new checkbox controls. |
| build/editor-plugin/plugin.asset.php | Updated asset version to reflect the changes. |
Comments suppressed due to low confidence (1)
src/editor-plugin/plugin.js:23
- [nitpick] The label 'Disable incoming' might benefit from additional clarity. Consider renaming it to 'Disable incoming webmentions' to clearly differentiate it from the 'Disable outgoing' option.
label={ __( 'Disable incoming', 'webmention' ) }
|
Want me to take a look? |
|
sure! |
|
@dshanske have you had the chance to check the PR? |
|
I planned to look this coming weekend. |
|
Requesting a Classic Editor fallback for this feature. |
|
@dshanske is that a requirement for this PR? |
|
In my opinion we should maintain compatibility for people who don't use the block editor. |
|
It was not an argument against it, simply the question if it should be part of this PR!? I am not very familar with the classic editor, so maybe you can give it a try in a separate PR? |
|
Looks good to me. Will do a separate PR to add backcompat https://make.wordpress.org/core/2018/11/07/meta-box-compatibility-flags/ |
fix #524