Debug/cuda errors for long sequences #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. make sure we don't know when not to apply scaling factors in cuda kernel
…otentially corrupt
1. seachsorted has undefined bahavior on empty arrays 2. intervals_to_values cuda kernel had unint32 being used as int32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The combination of long sequences and bigwig files with relatively sparse intervals data let completely empty (no chunks to decompress) for certain tracks in certain genomic regions. This in turn lead to a bug triggered by undefined behavior in our version of searchsorted that operates on multiple sorted arrays simultaneously, but could not handle some of the sorted arrays to be completely empty. This result of this was an int uint underflow followed by a overflow after a erroneous cast from uint32 to int32 in the intervals_to_values cuda kernel. This just did not show up yet before.