refactor(FullyQualifiedNamespace): Replace sniff in favor of a sniff from Slevomat

coder_sniffer/Drupal/ruleset.xml

@@ -111,7 +111,7 @@
 
   <!-- PSR-2 sniffs -->
   <rule ref="PSR2.Classes.PropertyDeclaration">
-     <!-- Already covered by Drupal.Classes.PropertyDeclaration.VarUsed. -->
+    <!-- Already covered by Drupal.Classes.PropertyDeclaration.VarUsed. -->
     <exclude name="PSR2.Classes.PropertyDeclaration.VarUsed"/>
   </rule>
   <rule ref="PSR2.Namespaces.NamespaceDeclaration"/>
@@ -120,6 +120,22 @@
   <!-- SlevomatCodingStandard sniffs -->
   <rule ref="SlevomatCodingStandard.Classes.BackedEnumTypeSpacing"/>
   <rule ref="SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator"/>
+  <!-- Allow global names with backslash like \Drupal. -->
+  <rule ref="SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly">
+    <properties>
+      <property name="allowFullyQualifiedGlobalClasses" value="true"/>
+      <property name="allowFullyQualifiedGlobalFunctions" value="true"/>
+      <property name="allowFullyQualifiedGlobalConstants" value="true"/>
+      <property name="allowFallbackGlobalFunctions" value="true"/>
+      <property name="allowFallbackGlobalConstants" value="true"/>
+    </properties>
+  </rule>
+  <rule ref="SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly.ReferenceViaFullyQualifiedName">
+    <exclude-pattern>*.api.php</exclude-pattern>
+  </rule>
+  <rule ref="SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly.ReferenceViaFullyQualifiedNameWithoutNamespace">
+    <severity>0</severity>
+  </rule>
   <rule ref="SlevomatCodingStandard.PHP.ShortList"/>
   <rule ref="SlevomatCodingStandard.TypeHints.DeclareStrictTypes">
     <exclude name="SlevomatCodingStandard.TypeHints.DeclareStrictTypes.DeclareStrictTypesMissing"/>

composer.json

@@ -18,7 +18,7 @@
         "ext-mbstring": "*",
         "dealerdirect/phpcodesniffer-composer-installer": "^0.7.1 || ^1.0.0",
         "sirbrillig/phpcs-variable-analysis": "^2.11.7",
-        "slevomat/coding-standard": "^8.11",
+        "slevomat/coding-standard": "^8.15",
         "squizlabs/php_codesniffer": "^3.11.2",
         "symfony/yaml": ">=3.4.0"
     },

tests/Drupal/Classes/ClassCreateInstanceUnitTest.inc.fixed

@@ -1,7 +1,7 @@
 <?php
 
-use Vendor\DateTools\DateInterval;
 use Vendor\DateTools;
+use Vendor\DateTools\DateInterval;
 
 $x = array(new Foo(), array());
 $y = new Foo();

tests/Drupal/Classes/UnusedUseStatementUnitTest.inc.fixed

@@ -2,9 +2,9 @@
 
 namespace MyNamespace\Depth;
 
-use Thing\NotUsed;
 use Thing\Fail\ActuallyUsed;
 use Test\TraitTest;
+use Thing\NotUsed;
 use Thing\DifferentName as UsedOtherName;
 use Example\MyUrlHelper;
 use MyNamespace\Depth\SomeClass as CoreSomeClass;

tests/Drupal/Commenting/ClassCommentUnitTest.inc.fixed

@@ -5,6 +5,8 @@
  * Testing class/trait comments.
  */
 
+use Some\Attribute;
+
 /**
  *
  */
@@ -60,7 +62,7 @@ class WrongSpacing {
 /**
  * This is correct.
  */
-#[Some\Attribute(foo: 'bar')]
+#[Attribute(foo: 'bar')]
 #[Other\Attribute(baz: 'qux')]
 class DoubleAttribute {
 

tests/Drupal/Commenting/FunctionCommentUnitTest.inc.fixed

@@ -5,6 +5,8 @@
  * Some function comment tests.
  */
 
+use Some\Attribute;
+
 /**
  * Test.
  *
@@ -579,7 +581,7 @@ class Test41 {
   /**
    * Method docblock.
    */
-  #[Some\Attribute(foo: 'bar')]
+  #[Attribute(foo: 'bar')]
   #[Other\Attribute(baz: 'qux')]
   public function method() {
   }

tests/Drupal/Classes/FullyQualifiedNamespaceUnitTest.1.inc.fixed → tests/Drupal/bad/BadFullyQualifiedNamespace.1.inc.fixed

@@ -8,7 +8,6 @@
  * without them.
  * phpcs:disable Drupal.Commenting
  */
-
 use Foo\Bar;
 
 /**