Skip to content

fix(LineLength): Do not check phpcs:ignore lines for line length #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 1, 2025
Merged

fix(LineLength): Do not check phpcs:ignore lines for line length #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions coder_sniffer/Drupal/Sniffs/Files/LineLengthSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@ class LineLengthSniff extends GenericLineLengthSniff
protected function checkLineLength($phpcsFile, $tokens, $stackPtr)
{
if (isset(Tokens::$commentTokens[$tokens[($stackPtr - 1)]['code']]) === true) {
// Allow any PHPCS ignore comments to exceed the 80 character limit.
if (isset(Tokens::$phpcsCommentTokens[$tokens[($stackPtr - 1)]['code']]) === true) {
return;
}

$docCommentTag = $phpcsFile->findFirstOnLine(T_DOC_COMMENT_TAG, ($stackPtr - 1));
if ($docCommentTag !== false) {
// Allow doc comment tags such as long @param tags to exceed the 80
Expand Down
11 changes: 10 additions & 1 deletion tests/Drupal/Files/LineLengthUnitTest.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,13 @@

function foo() {
echo 'test';
}//end foo()
}//end foo()

class Test {

/**
* The search score.
*/
public string $search_score; // phpcs:ignore Drupal.NamingConventions.ValidVariableName.LowerCamelName

}
Loading