Skip to content

feat(EmptyPHPStatement): Add sniff for empty PHP statements, same as Drupal core does #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2025
Merged

feat(EmptyPHPStatement): Add sniff for empty PHP statements, same as Drupal core does #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions coder_sniffer/Drupal/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,16 +47,18 @@
<exclude-pattern>*.tpl.php</exclude-pattern>
</rule>

<!-- Generic sniffs -->
<rule ref="Generic.CodeAnalysis.EmptyPHPStatement"/>
<rule ref="Generic.CodeAnalysis.UselessOverridingMethod"/>
<rule ref="Generic.Files.ByteOrderMark"/>
<rule ref="Generic.Files.LineEndings"/>
<rule ref="Generic.Formatting.DisallowMultipleStatements"/>
<rule ref="Generic.Formatting.SpaceAfterCast"/>

<rule ref="Generic.Functions.FunctionCallArgumentSpacing"/>
<!-- Already covered by Drupal.WhiteSpace.Comma.NoSpace. -->
<rule ref="Generic.Functions.FunctionCallArgumentSpacing.NoSpaceAfterComma">
<severity>0</severity>
</rule>

<rule ref="Generic.NamingConventions.ConstructorName"/>
<rule ref="Generic.NamingConventions.UpperCaseConstantName"/>
<rule ref="Generic.PHP.DeprecatedFunctions"/>
Expand All @@ -65,13 +67,6 @@
<rule ref="Generic.PHP.UpperCaseConstant"/>
<rule ref="Generic.WhiteSpace.DisallowTabIndent"/>

<!-- Use Unix newlines -->
<rule ref="Generic.Files.LineEndings">
<properties>
<property name="eolChar" value="\n"/>
</properties>
</rule>

<rule ref="MySource.Debug.DebugCode"/>
<rule ref="PEAR.Files.IncludingFile"/>
<!-- Disable some error messages that we do not want. -->
Expand Down
1 change: 1 addition & 0 deletions tests/Drupal/bad/BadUnitTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,7 @@ protected function getWarningList(string $testFile): array
809 => 1,
823 => 1,
824 => 1,
836 => 1,
];
}//end switch

Expand Down
1 change: 0 additions & 1 deletion tests/Drupal/bad/bad.php.fixed
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -884,7 +884,6 @@ function test28() {

// Multiple statements on one line are not allowed.
echo 'Hi!';
;

/**
*
Expand Down
Loading