Issue #3516489 disregard phpstan-ignore comments in front of function declaration #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan1055
force-pushed
the
3516489-phpstan-ignore
branch
from
588914e to
e912b6f
Compare
klausi
reviewed
May 18, 2025
coder_sniffer/Drupal/Sniffs/Commenting/FunctionCommentSniff.php
Outdated
Show resolved
Hide resolved
jonathan1055
commented
May 19, 2025
tests/Drupal/good/good.php
Outdated
| } | ||
|
|
||
| t('Some long mulit-line | ||
| t('Some long mulit-line |
There was a problem hiding this comment.
My editor automatically removed trailing spaces. Was this space needed? If so, this change should be reverted.
There was a problem hiding this comment.
yeah, we need this space for testing
There was a problem hiding this comment.
That's intersting, because all the tests passed without it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drupal issue https://www.drupal.org/project/coder/issues/3516489