-
Notifications
You must be signed in to change notification settings - Fork 53
Issue #3516489 disregard phpstan-ignore comments in front of function declaration #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
a7018b1
Initial commit
jonathan1055 457f773
Fix 2 x phpcs
jonathan1055 87d0940
remove x
jonathan1055 30eac2a
change true to 1
jonathan1055 e912b6f
Simplify by using same tactic as phpcs comments
jonathan1055 a150c02
Add first case to good.php
jonathan1055 c445c99
add tokenIsPhpstanComment() function
jonathan1055 e3434b1
Merge branch '8.3.x' into 3516489-phpstan-ignore
jonathan1055 23d37a5
Simplify the example in good.php
jonathan1055 53963f6
Add array value type to fix phpstan
jonathan1055 8e93fa1
revert unintended trailing-blank change
jonathan1055 b752a4b
Add two more test cases
jonathan1055 34981a1
Remove 3rd test example
jonathan1055 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My editor automatically removed trailing spaces. Was this space needed? If so, this change should be reverted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, we need this space for testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's intersting, because all the tests passed without it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted.