Adopt new form elements for update notifications during site installation #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this version a change was introduced to the installation forms. This affects the way the installation needs to be performed. See https://www.drupal.org/node/2691971
Added composer validate to CI.
jcnventura
reviewed
Oct 13, 2017
composer.json
Outdated
| "drupal/core": "~8.0", | ||
| "drupal/core": "~8.3", | ||
| "drush/drush": "~8.0", | ||
| "php": ">=5.5.9", |
There was a problem hiding this comment.
You should remove the php requirement.. Drupal's PHP requirement is already in Drupal's composer.json.
This is already specified by our dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Issue #2691971: "Update Notifications" #title repeated for drupal 8 installation in configure site page the form got reworked that allows to configure whether notifications should be sent about module updates during site installation. This will soon be released with Drupal 8.3.0.
This PR adopts these changes to the installer, so the builds can still run without errors on systems that have no mail transfer agent installed.