Feature: Add few missing entry support to openvpn_server#152
Merged
opoplawski merged 6 commits intopfsensible:masterfrom Apr 14, 2025
Merged
Feature: Add few missing entry support to openvpn_server#152opoplawski merged 6 commits intopfsensible:masterfrom
opoplawski merged 6 commits intopfsensible:masterfrom
Conversation
opoplawski
requested changes
Jan 26, 2025
Contributor
opoplawski
left a comment
opoplawski
left a comment
There was a problem hiding this comment.
Thanks for the PR. We'll need version_added doc fields for the new options - let's go with 0.6.2 for now. Also a changelog fragment is needed.
Contributor
|
Just a note that the dev version has been bumped to 0.7.0 |
Inocious
commented
Mar 25, 2025
Contributor
Author
Inocious
left a comment
Inocious
left a comment
There was a problem hiding this comment.
Sorry for delay. Code modified.
Contributor
Author
|
@opoplawski It says files changed => "71". My initial commit was '2' files only I suspect it because I merged v0.6.2 to my-fork before doing my commit (that was in v0.6.1). |
Contributor
|
Couple suggestions:
I've done this now to your branch. |
opoplawski
force-pushed
the
master
branch
2 times, most recently
from
4ef5272 to
b61034b
Compare
opoplawski
approved these changes
Apr 14, 2025
…timeout and exit_notify features
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit will add remote_cert_tls, inactive_seconds, keepalive_interval, keepalive_timeout and exit_notify features to pfsensible.core.pfsense_openvpn_server module