Skip to content

Conversation

@mmols
Copy link
Member

@mmols mmols commented Mar 10, 2025

  • Display default values consistently across inputs
  • Fix issue where spock versions with revisions would be truncated
  • Improve json-create summary output

Fixes along the way:

  • Hide HA note in summary
  • Remove release codename (for now)
$ ./pgedge cluster json-create default 2 defaultdb admin password
PostgreSQL version ['15', '16', '17'] (default: '16'):
Spock version ['3.3.6', '3.3.5', '4.0.10', '4.0.9', '4.0.8'] (default: '4.0.10'):
Enable pgBackRest? (Y/N) (default: 'N'): Y
   pgBackRest storage path (default: '/var/lib/pgbackrest'):
   pgBackRest archive mode (on/off) (default: 'on'):
   pgBackRest repository type (posix/s3) (default: 'posix'):

Configuring Node 1
  Public IP address for Node 1 (default: '127.0.0.1'):
  Private IP address for Node 1 (default: '127.0.0.1'):
  PostgreSQL port for Node 1 (default: '5432'):

Configuring Node 2
  Public IP address for Node 2 (default: '127.0.0.1'):
  Private IP address for Node 2 (default: '127.0.0.1'):
  PostgreSQL port for Node 2 (default: '5432'):

################################################################################
# Cluster Name       : default
# PostgreSQL Version : 16
# Spock Version      : 4.0.10
# Number of Nodes    : 2
# Database Name      : defaultdb
# User               : admin
# pgBackRest Enabled : Yes
#    Storage Path    : /var/lib/pgbackrest
#    Archive Mode    : on
#    Repository Type : posix
# Node 1
#    Public IP       : 127.0.0.1
#    Private IP      : 127.0.0.1
#    Port            : 5432
# Node 2
#    Public IP       : 127.0.0.1
#    Private IP      : 127.0.0.1
#    Port            : 5432
################################################################################
Do you want to save this configuration? (Y/N): Y

Cluster configuration saved to /home/pgedge/pgedge/cluster/default/default.json

@mmols mmols requested a review from moizpgedge March 10, 2025 21:57
ha REMOVED
@mmols
Copy link
Member Author

mmols commented Mar 11, 2025

Cleanup before merge:

  • Remove HA in helptext in cluster module

@mmols mmols merged commit b3c2975 into REL25_01 Mar 12, 2025
9 checks passed
@mmols mmols deleted the json-create-versions branch March 12, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants