Open
Conversation
📝 WalkthroughWalkthroughThis pull request updates test data to reference newer database versions and adds new image mappings for PgEdge database versions 16.13, 17.9, and 18.3 in the orchestrator configuration. Changes
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
server/internal/orchestrator/swarm/images.go (1)
38-40: Track mutable-tag cleanup explicitly to avoid silent version drift.These new mappings are valid, but since they key a fixed minor version to mutable tags, adding a short TODO/issue marker beside each entry will make replacement with immutable tags auditable and reduce long-term ambiguity.
Suggested minimal diff
versions.addImage(host.MustPgEdgeVersion("16.13", "5"), &Images{ + // TODO(PLAT-449): replace with immutable 16.13 image tag once published. PgEdgeImage: imageTag(cfg, "16-spock5-standard"), }) @@ versions.addImage(host.MustPgEdgeVersion("17.9", "5"), &Images{ + // TODO(PLAT-449): replace with immutable 17.9 image tag once published. PgEdgeImage: imageTag(cfg, "17-spock5-standard"), }) @@ versions.addImage(host.MustPgEdgeVersion("18.3", "5"), &Images{ + // TODO(PLAT-449): replace with immutable 18.3 image tag once published. PgEdgeImage: imageTag(cfg, "18-spock5-standard"), })Also applies to: 52-54, 66-68
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@server/internal/orchestrator/swarm/images.go` around lines 38 - 40, The mapping entries using versions.addImage with host.MustPgEdgeVersion and mutable image tags (e.g., the Images struct's PgEdgeImage set via imageTag(cfg, "16-spock5-standard")) need an explicit TODO/issue marker to track future replacement with immutable tags; update each affected entry (including the ones referenced around lines 52–54 and 66–68) by adding a short comment like "TODO: replace mutable tag with immutable digest (issue #...)" adjacent to the versions.addImage call so the mutable-tag cleanup is auditable and discoverable.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@server/internal/orchestrator/swarm/images.go`:
- Around line 38-40: The mapping entries using versions.addImage with
host.MustPgEdgeVersion and mutable image tags (e.g., the Images struct's
PgEdgeImage set via imageTag(cfg, "16-spock5-standard")) need an explicit
TODO/issue marker to track future replacement with immutable tags; update each
affected entry (including the ones referenced around lines 52–54 and 66–68) by
adding a short comment like "TODO: replace mutable tag with immutable digest
(issue #...)" adjacent to the versions.addImage call so the mutable-tag cleanup
is auditable and discoverable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update Control Plane’s Postgres image/version mapping to include PG 16.13, 17.9, and 18.3 for upcoming minor releases, while using mutable image tags for the new minors until immutable tags are published.
Changes
Checklist