Conversation
jason-lynch
force-pushed
the
feat/PLAT-86/validations-in-openapi-spec
branch
from
7296140 to
0d9bf7d
Compare
jason-lynch
force-pushed
the
feat/PLAT-86/api-versioning
branch
from
d317905 to
9982dcb
Compare
jason-lynch
force-pushed
the
feat/PLAT-86/validations-in-openapi-spec
branch
from
0d9bf7d to
507bfb2
Compare
jason-lynch
force-pushed
the
feat/PLAT-86/api-versioning
branch
from
9982dcb to
53581e5
Compare
jason-lynch
force-pushed
the
feat/PLAT-86/api-versioning
branch
from
53581e5 to
5b41bfb
Compare
jason-lynch
force-pushed
the
feat/PLAT-86/validations-in-openapi-spec
branch
from
507bfb2 to
b10d80f
Compare
jason-lynch
force-pushed
the
feat/PLAT-86/api-versioning
branch
from
5b41bfb to
048573b
Compare
jason-lynch
force-pushed
the
feat/PLAT-86/validations-in-openapi-spec
branch
from
b10d80f to
9ca4728
Compare
jason-lynch
force-pushed
the
feat/PLAT-86/api-versioning
branch
2 times, most recently
from
a02a22d to
af80869
Compare
jason-lynch
force-pushed
the
feat/PLAT-86/validations-in-openapi-spec
branch
from
9ca4728 to
20fffd1
Compare
jason-lynch
force-pushed
the
feat/PLAT-86/api-versioning
branch
from
af80869 to
b819f4c
Compare
jason-lynch
force-pushed
the
feat/PLAT-86/validations-in-openapi-spec
branch
from
20fffd1 to
8fe113d
Compare
jason-lynch
force-pushed
the
feat/PLAT-86/api-versioning
branch
2 times, most recently
from
dcdcc7c to
5fe392b
Compare
tsivaprasad
reviewed
Jun 16, 2025
tsivaprasad
approved these changes
Jun 16, 2025
Contributor
tsivaprasad
left a comment
tsivaprasad
left a comment
There was a problem hiding this comment.
Verified a few commands like list-databases, create-database, etc., and they are all correctly pointing to the v1 API and working as expected.
mmols
approved these changes
Jun 16, 2025
Base automatically changed from
feat/PLAT-86/validations-in-openapi-spec
to
main
June 16, 2025 18:50
This commit adds versioning to our API endpoints, with the current version as `v1`. Under this scheme, each API version lives under separate packages and is served under separate top-level prefixes, e.g. `/v1` for the current version. This necessitated a small refactor to make it easier to modularize the initialization logic. PLAT-86
jason-lynch
force-pushed
the
feat/PLAT-86/api-versioning
branch
from
5fe392b to
7c5d64c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds versioning to our API endpoints, with the current version as
v1. Under this scheme, each API version lives under separate packages and is served under separate top-level prefixes, e.g./v1for the current version.This necessitated a small refactor to make it easier to modularize the initialization logic.
NOTE: you will need to update your restish configuration to add the
/v1prefix to each server. See the development doc diffs for more details. Remember to runrestish api control-plane-local-<1,2,3> syncafter updating the restish config.PLAT-86