Merged
Conversation
208a3da to
fde0f2c
Compare
ec4cc92 to
d026649
Compare
87f64ba to
1293ea0
Compare
1293ea0 to
8511659
Compare
d026649 to
f1d628a
Compare
8511659 to
ed23079
Compare
mmols
approved these changes
Jun 16, 2025
tsivaprasad
reviewed
Jun 17, 2025
This modifies our API contract to allow human-readable IDs, as opposed to UUIDs, in each user-specified ID field: - Cluster ID - Host ID - Database ID - Tenant ID Instance IDs are still deterministically generated from the host ID, database ID, and node name, but are designed to be more readable. For example, given these inputs: - Host ID: "us-east-1" - Database ID: "my-app" - Node name: "n1" We will generate the instance ID "my-app-n1-n5fe2mcy". We're using a short hash of the host ID rather than the host ID itself to enhance readability when the host IDs are long, such as those used by Cloud. For example, when both the host ID and database ID are UUIDs: - Host ID: "dbf5779c-492a-11f0-b11a-1b8cb15693a8" - Database ID: "ed2362ea-492a-11f0-956c-9f2171e8b9ab" - Node name: "n1" The instance ID is "ed2362ea-492a-11f0-956c-9f2171e8b9ab-n1-io5979nh" This commit contains breaking changes for the development environment, so it's recommended to do the following before updating to this commit: - Delete all databases via the API - Remove existing data directories: `rm -rf docker/control-plane-dev/data` This will reset your environment, so you'll need to reinitialize the cluster. PLAT-86
ed23079 to
8647b1a
Compare
tsivaprasad
approved these changes
Jun 17, 2025
Contributor
tsivaprasad
left a comment
There was a problem hiding this comment.
Verified:
database-output.json
task-log.json
jason-lynch
added a commit
that referenced
this pull request
Jul 21, 2025
We made the node name part of the instance ID in #57. Since the instance ID is included in the service name and the instance's hostname, it's unnecessary to also include the node name. This diff illustrates the change to both the host and service names: ```diff 1c1 < postgres-n1-storefront-n1-689qacsi --- > postgres-storefront-n1-689qacsi ```` PLAT-188
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies our API contract to allow human-readable IDs, as opposed to UUIDs, in each user-specified ID field:
Instance IDs are still deterministically generated from the host ID, database ID, and node name, but are designed to be more readable. For example, given these inputs:
We will generate the instance ID "my-app-n1-n5fe2mcy". We're using a short hash of the host ID rather than the host ID itself to enhance readability when the host IDs are long, such as those used by Cloud. For example, when both the host ID and database ID are UUIDs:
The instance ID is "ed2362ea-492a-11f0-956c-9f2171e8b9ab-n1-io5979nh"
This commit contains breaking changes for the development environment, so it's recommended to do the following before updating to this commit:
rm -rf docker/control-plane-dev/dataThis will reset your environment, so you'll need to reinitialize the cluster.
get-databaseresponse example with new IDsPLAT-86