Merged
Conversation
The `pgbackrest info` output contains a non-zero status code if the repository is empty, even if it's otherwise configured correctly. We were returning a `resource.ErrNotFound` in this case, which caused us to re-run the `PgBackRestStanza.Create` method unnecessarily. The `Create` implementation is idempotent, so this didn't cause issues, but it was confusing to see the create event in the output when there were no changes.
mmols
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pgbackrest infooutput contains a non-zero status code if the repository is empty, even if it's otherwise configured correctly. We were returning aresource.ErrNotFoundin this case, which caused us to re-run thePgBackRestStanza.Createmethod unnecessarily. TheCreateimplementation is idempotent, so this didn't cause issues, but it was confusing to see the create event in the output when there were no changes.