-
Notifications
You must be signed in to change notification settings - Fork 2
Updates lolor, PostGIS and pgedge_vectorizer and adds system_stats extension #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3d1df7e to
2469ec1
Compare
📝 WalkthroughWalkthroughUpdates bump pgedge-lolor from 1.2.1-1.el9 to 1.2.2-1.el9 across multiple minimal and standard package lists (amd64 and arm64) for several PostgreSQL versions. Standard manifests also bump pgedge-postgis35, promote pgedge-vectorizer to beta2, and add pgedge-system_stats. The image build script epochs are incremented by +1 (2→3 and 3→4). Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…n standard images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@packagelists/arm64/pg18.0-spock5.0.4-standard.txt`:
- Around line 16-17: The packagelist includes
pgedge-vectorizer_18-1.0-beta2_1.el9 (beta) and
pgedge-system_stats_18-3.2.1-1.el9 intentionally for all standard images;
confirm that the beta vectorizer is acceptable for production and that
system_stats should indeed be in the standard (not minimal) flavor, and either
(a) document this decision in the packagelist file with a short comment
referencing pgedge-vectorizer_18-1.0-beta2_1.el9 and
pgedge-system_stats_18-3.2.1-1.el9, or (b) if unacceptable, remove or pin to a
stable version and update the packagelist accordingly; also validate against
pgEdge package docs for known issues and update release notes/configs to reflect
the choice.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (12)
packagelists/amd64/pg16.10-spock5.0.4-standard.txtpackagelists/amd64/pg16.11-spock5.0.4-standard.txtpackagelists/amd64/pg17.6-spock5.0.4-standard.txtpackagelists/amd64/pg17.7-spock5.0.4-standard.txtpackagelists/amd64/pg18.0-spock5.0.4-standard.txtpackagelists/amd64/pg18.1-spock5.0.4-standard.txtpackagelists/arm64/pg16.10-spock5.0.4-standard.txtpackagelists/arm64/pg16.11-spock5.0.4-standard.txtpackagelists/arm64/pg17.6-spock5.0.4-standard.txtpackagelists/arm64/pg17.7-spock5.0.4-standard.txtpackagelists/arm64/pg18.0-spock5.0.4-standard.txtpackagelists/arm64/pg18.1-spock5.0.4-standard.txt
🚧 Files skipped from review as they are similar to previous changes (4)
- packagelists/amd64/pg16.10-spock5.0.4-standard.txt
- packagelists/arm64/pg16.11-spock5.0.4-standard.txt
- packagelists/arm64/pg16.10-spock5.0.4-standard.txt
- packagelists/arm64/pg18.1-spock5.0.4-standard.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
- GitHub Check: test (16.11-spock5.0.4-standard-4, arm, standard, ubuntu-24.04-arm)
- GitHub Check: test (17.7-spock5.0.4-minimal-4, x86, minimal, ubuntu-latest)
- GitHub Check: test (18.1-spock5.0.4-standard-4, arm, standard, ubuntu-24.04-arm)
- GitHub Check: test (18.1-spock5.0.4-standard-4, x86, standard, ubuntu-latest)
- GitHub Check: test (17.7-spock5.0.4-standard-4, arm, standard, ubuntu-24.04-arm)
- GitHub Check: test (18.1-spock5.0.4-minimal-4, arm, minimal, ubuntu-24.04-arm)
- GitHub Check: test (18.1-spock5.0.4-minimal-4, x86, minimal, ubuntu-latest)
- GitHub Check: test (16.11-spock5.0.4-minimal-4, x86, minimal, ubuntu-latest)
- GitHub Check: test (17.7-spock5.0.4-minimal-4, arm, minimal, ubuntu-24.04-arm)
- GitHub Check: test (16.11-spock5.0.4-minimal-4, arm, minimal, ubuntu-24.04-arm)
- GitHub Check: test (16.11-spock5.0.4-standard-4, x86, standard, ubuntu-latest)
- GitHub Check: test (17.7-spock5.0.4-standard-4, x86, standard, ubuntu-latest)
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (11)
packagelists/amd64/pg18.1-spock5.0.4-standard.txt (4)
4-4: LGTM! Lolor version update verified and consistent across all package lists.The lolor version update from 1.2.1 to 1.2.2 is complete and consistently applied across all relevant package lists (amd64/arm64, minimal/standard variants for PostgreSQL 16, 17, and 18). No orphaned 1.2.1 references remain.
17-17: Thepgedge-system_statspackage addition is intentional and consistent. It is systematically added across all PostgreSQL versions (16, 17, 18) and both architectures (amd64, arm64) in the standard image variant, while appropriately excluded from minimal variants. The version numbering follows the correct pattern (system_stats_16/17/18 matching the PostgreSQL major version) with version 3.2.1 used consistently. This is a deliberate inclusion for the standard variant, not accidental scope creep.
6-6: Verify the postgis35 version update is intentional.The PR title mentions only the lolor update, but this line shows a postgis35 package update. Please confirm whether this update is intentional and part of the same release cycle, or if it should be in a separate PR for clarity.
#!/bin/bash # Check all postgis35 version references across package lists echo "=== Finding all postgis35 package references ===" rg -n 'pgedge-postgis35' packagelists/ | head -20
16-16: Remove or document the non-existent pgedge-vectorizer version.The pgedge-vectorizer version
1.0-beta2_1.el9does not appear in any official pgEdge release documentation or changelog. Official releases only reference1.0-beta1and earlier alphas. This version is consistently used across all standard image variants (PostgreSQL 16–18) but is absent from minimal variants and the CHANGELOG.Clarify whether:
- This is a custom internal build and should be documented
- This is a typo and should be
1.0-beta1- The version should be sourced from a documented private repository
packagelists/amd64/pg18.0-spock5.0.4-standard.txt (1)
4-4: Package updates are consistent with other manifests.The version updates for PostgreSQL 18 packages match the pattern across all manifests in this PR. The changes maintain consistency across different PostgreSQL versions.
Also applies to: 6-6, 16-17
packagelists/amd64/pg17.6-spock5.0.4-standard.txt (1)
4-4: LGTM - Consistent package updates.Package versions are updated consistently with other PostgreSQL 17.x manifests.
Also applies to: 6-6, 16-17
packagelists/amd64/pg17.7-spock5.0.4-standard.txt (1)
4-4: LGTM - Architecture consistency maintained.The AMD64 package versions match the ARM64 manifest for PostgreSQL 17.7.
Also applies to: 6-6, 16-17
packagelists/amd64/pg16.11-spock5.0.4-standard.txt (1)
4-4: LGTM - Package updates are complete and consistent.The PostgreSQL 16 packages follow the same update pattern as versions 17 and 18. All changes across the reviewed manifests are consistent.
Note: The PR title mentions only "lolor version to 1.2.2" but this PR also updates postgis35 (to 3.5.4), vectorizer (to beta2), and adds system_stats (3.2.1). Consider updating the PR title or description to reflect the full scope of changes.
Also applies to: 6-6, 16-17
packagelists/arm64/pg17.7-spock5.0.4-standard.txt (1)
4-4: New manifest file for PostgreSQL 17.7 arm64 standard image is properly formatted.This new file adds package entries that follow the consistent pgedge naming convention (pgedge-_--.el9). All packages are properly versioned with semantic versioning, including the PostGIS 3.5.4 upgrade, vectorizer 1.0-beta2, and new system_stats 3.2.1 extension.
packagelists/arm64/pg17.6-spock5.0.4-standard.txt (1)
4-4: LGTM - Consistent updates across PostgreSQL versions.The package version updates mirror the PG18 variant consistently:
- lolor: 1.2.2-1.el9
- postgis35: 3.5.4-1.el9
- vectorizer: 1.0-beta2_1.el9
- system_stats: 3.2.1-1.el9 (new)
Ensure these package builds with the
_17suffix are compatible with PostgreSQL 17.6 before merging.packagelists/arm64/pg18.0-spock5.0.4-standard.txt (1)
4-4: The lolor package version 1.2.2-1.el9 is a legitimate pgEdge-maintained extension with no known security vulnerabilities. This version is consistently used across all PostgreSQL versions and architectures in the package lists.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
This reverts commit c788156.
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.