Skip to content

Spoc 384 (second part) #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mason-sharp merged 5 commits into from
Jan 9, 2026
Merged

Spoc 384 (second part) #298

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b817e29
Remove the spock_group_lookup routine.
danolivo Dec 24, 2025
49696e3
apply_worker_get_progress: access to the progress state under a lock.
danolivo Dec 24, 2025
bdbce0a
Remove redundant parameter from the adjust_progress_info.
danolivo Dec 29, 2025
68dc610
During subscription syncing, take progress info more consistently.
danolivo Dec 29, 2025
a133f2a
Replace memcpy with structure assignment in apply_worker_get_progress
danolivo Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions src/spock_group.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,18 +394,32 @@ spock_group_progress_update_ptr(SpockGroupEntry *e,
/*
* apply_worker_get_progress
*
* Return a pointer to the current apply worker's progress payload, or NULL
* Return a pointer to the snapshot of the current apply worker's progress.
*/
SpockApplyProgress *
apply_worker_get_progress(void)
{
static SpockApplyProgress sap;

Assert(MyApplyWorker != NULL);
Assert(MyApplyWorker->apply_group != NULL);

if (MyApplyWorker && MyApplyWorker->apply_group)
return &MyApplyWorker->apply_group->progress;
{
LWLockAcquire(SpockCtx->apply_group_master_lock, LW_SHARED);

memcpy(&sap, &MyApplyWorker->apply_group->progress,
sizeof(SpockApplyProgress));
LWLockRelease(SpockCtx->apply_group_master_lock);
}
else
/*
* Should never happen. In production just send the worker into
* exception behaviour without crash.
*/
elog(ERROR, "apply worker has not been fully initialised yet");

return NULL;
return &sap;
}

/* Iterate all groups */
Expand Down