[SPOC-83] Refactor test container for running regression tests#82
Merged
[SPOC-83] Refactor test container for running regression tests#82
Conversation
mason-sharp
force-pushed
the
task/SPOC-83-docker-regress-refactor
branch
from
bf88751 to
aabc300
Compare
pct960
approved these changes
Jul 11, 2025
|
|
||
| WORKDIR /home/pgedge | ||
| RUN echo "Cloning Spock at $GITHUB_REF from $REPO_URL" | ||
| RUN git clone ${REPO_URL} |
Contributor
There was a problem hiding this comment.
The repo is already checked out by the action. For the next update, we could perhaps simply copy the files while building the image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously Postgres and Spock were compiled in entrypoint.sh as part of running spockbench. This is now moved to building these in the container, allowing us to use the same container to run regression tests as a separate step that can also be more easily viewed in the github workflow output.