Skip to content

pgr_extractVertices promoted to official #2773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cvvergara merged 2 commits into from
Mar 2, 2025
Merged

pgr_extractVertices promoted to official #2773

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fdb120
pgr_extractVertices promoted to official
cvvergara Feb 26, 2025
1fce8c9
Update locale: commit 4fdb120d1
github-actions[bot] Mar 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,14 @@

### pgRouting 3.8.0 Release Notes

**Changes on proposed functions**
**Promotion to official function of pgRouting.**

* pgr_extractVertices

* Error messages adjustment.
* Function promoted to official.

Comment on lines +11 to +17
Copy link
Contributor

@coderabbitai coderabbitai bot Mar 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Release Note Clarity for pgr_extractVertices
The NEWS.md file now includes a heading “Promotion to official function of pgRouting.” with a subsequent listing for pgr_extractVertices that contains an “Error messages adjustment” bullet and then “* Function promoted to official.” This entry clearly reflects the new status.

A minor suggestion: Markdownlint (MD036) flagged that emphasis was used instead of a proper heading. Consider using a hash-based heading (e.g. using “###”) to improve clarity if it aligns with your formatting guidelines.

**Changes on proposed functions**

* pgr_findCloseEdges

Expand Down
4 changes: 3 additions & 1 deletion doc/src/release_notes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,16 @@ pgRouting 3.8
pgRouting 3.8.0 Release Notes
-------------------------------------------------------------------------------

.. rubric:: Changes on proposed functions
.. rubric:: Promotion to official function of pgRouting.

* pgr_extractVertices

.. include:: pgr_extractVertices.rst
:start-after: Version 3.8.0
:end-before: .. rubric

.. rubric:: Changes on proposed functions

* pgr_findCloseEdges

.. include:: pgr_findCloseEdges.rst
Expand Down
10 changes: 3 additions & 7 deletions doc/topology/pgr_extractVertices.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,25 +9,21 @@

.. index::
single: Topology Family ; pgr_extractVertices
single: extractVertices - Proposed on v3.3
single: extractVertices

Comment on lines 10 to 13
Copy link
Contributor

@coderabbitai coderabbitai bot Mar 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Index Entry Consistency
At line 11–13 the index is updated with a new entry “single: extractVertices”. Please confirm that this new index entry duplicates or replaces the earlier “Topology Family ; pgr_extractVertices” as intended. If the earlier entry is no longer needed, consider removing it to avoid any ambiguity.

|

``pgr_extractVertices`` -- Proposed
``pgr_extractVertices``
===============================================================================

``pgr_extractVertices`` — Extracts the vertices information


.. include:: proposed.rst
:start-after: warning-begin
:end-before: end-warning

.. rubric:: Availability

.. rubric:: Version 3.8.0

* Error messages adjustment.
* Function promoted to official.

.. rubric:: Version 3.3.0

Expand Down
4 changes: 2 additions & 2 deletions doc/topology/topology-functions.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ have special permissions given by the administrators to use them.
table.
- :doc:`pgr_analyzeOneWay` - to analyze directionality of the edges.
- :doc:`pgr_nodeNetwork` - to create nodes to a not noded edge table.
- :doc:`pgr_extractVertices` - Extracts vertex information based on the edge
table information.

.. official-end

Expand All @@ -60,8 +62,6 @@ Additional functions to analyze a graph:
These proposed functions do not modify the database.

- :doc:`pgr_degree` - Returns a set of vertices and corresponding count of incidet edges to the vertex.
- :doc:`pgr_extractVertices` - Extracts vertex information based on the edge
table information.

.. proposed-end

Expand Down
1 change: 0 additions & 1 deletion sql/topology/extractVertices.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,6 @@ LANGUAGE plpgsql VOLATILE STRICT;

COMMENT ON FUNCTION pgr_extractVertices(TEXT, BOOLEAN)
IS 'pgr_extractVertices
- PROPOSED
- Parameters
- Edges SQL with columns: [id,] startpoint, endpoint
OR
Expand Down