Skip to content

Port 3.8.0 changes #2777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cvvergara merged 22 commits into from
Mar 8, 2025
Merged

Port 3.8.0 changes #2777

cvvergara merged 22 commits into from
Mar 8, 2025

Conversation

@cvvergara
Copy link
Member

@cvvergara cvvergara commented Mar 3, 2025

Ports changes done on version 3.8.0

@cvvergara cvvergara added this to the Release 4.0.0 milestone Mar 3, 2025
@cvvergara cvvergara self-assigned this Mar 3, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 3, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cvvergara cvvergara force-pushed the port-3.8.0-changes branch from 0a7d6f6 to 52a1305 Compare March 4, 2025 03:30
cvvergara added 13 commits March 4, 2025 15:08
@cvvergara
Adjusting pumpup to set minor version in locale files
2e1aada 
(cherry picked from commit 2fb54e4)
@cvvergara
Pump up to 3.8.0
d5d781c 
(cherry picked from commit acb9bd1)
@cvvergara
Fixing code rabit issues
74ea7cb 
(cherry picked from commit 6095aa3)
@cvvergara
Adjusting page_history.js fixed logic to have shorter array of renames
930ddbd 
(cherry picked from commit a5196af)
@cvvergara
Using rabbit recomendations
338c254 
(cherry picked from commit 720fe01)
@cvvergara
renaming: spanningTree-family.rst -> spanningTree-category.rst
ecf33a5 
(cherry picked from commit ad95e50)
@cvvergara
(internal SQL) Throw PostgreSQL errmsg, hint and error code
3d61bf8 
- Internal functions
  - _pgr_checkquery
  - _pgr_checkcolumn

- re-throw from
  - pgr_extractVertices
  - pgr_findCloseEdges
  - pgr_degree

- Adding tests for missing column and relation not found
- (pgtap) adjusting tests because of changes on internal SQL
- Documentation of the changes

(cherry picked from commit 373dd66)
@cvvergara
Work on rabbit suggestions
4eab81d 
(cherry picked from commit 695af1e)
@cvvergara
pgr_extractVertices promoted to official
45a21fd 
(cherry picked from commit 4fdb120)
@cvvergara
(pgr_findCloseEdges) Remove partial option
6469ed0 
- New SQL without partial parameter
- Deprecation of SQL with partial parameter
- Update script adjustment
- Documentation cleanup
  - Using the function on the sample data and concepts
  - Remove examples with partial parameter
- pgTap tests
  - (tools) New function to pgtap function types
  - Added tests for the deprecated signature as is still usable
- Updated release notes and NEWS

(cherry picked from commit b95eb83)
@cvvergara
(pgtap/degree) add todo on edge_cases test
513fc33 
(cherry picked from commit 3ee3565)
@cvvergara
(pgr_findCloseEdges) promotion to official
588391f 
(cherry picked from commit a02e055)
@cvvergara
Collapse warnings of proposed and expermiental
b9fb7a1 
- fix some spelling mistakes

(cherry picked from commit 99ba589)
@cvvergara cvvergara force-pushed the port-3.8.0-changes branch from 52a9022 to b9fb7a1 Compare March 4, 2025 21:17
@cvvergara cvvergara marked this pull request as ready for review March 6, 2025 20:16
@cvvergara cvvergara requested a review from robe2 March 6, 2025 20:16
@cvvergara
(pgtap/trsp) Refining when the test are performed
222db36 
- lib version  < 4.0 AND Version >= 3.4
- lib version >= 4.0 AND Version >= 3.6
@cvvergara cvvergara force-pushed the port-3.8.0-changes branch from a8348fe to 2e4d15d Compare March 8, 2025 15:10
@cvvergara cvvergara force-pushed the port-3.8.0-changes branch from 2e4d15d to 930f748 Compare March 8, 2025 15:17
@cvvergara cvvergara force-pushed the port-3.8.0-changes branch from 9eee7d3 to f3b0d40 Compare March 8, 2025 15:35
@cvvergara cvvergara merged commit f63aacb into pgRouting:develop Mar 8, 2025
26 checks passed
@cvvergara cvvergara deleted the port-3.8.0-changes branch March 8, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robe2 robe2 robe2 approved these changes

Assignees

@cvvergara cvvergara

Labels

Administrative

Projects

None yet

Milestone

Release 4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@cvvergara @robe2