Ci update test fix #2784
Ci update test fix #2784
Conversation
WalkthroughThis pull request updates several GitHub Actions workflows to install the new Python package Changes
Sequence Diagram(s)sequenceDiagram
participant Script as PL/pgSQL Script
participant DB as PostgreSQL
Script->>DB: Call pgr_version()
DB-->>Script: Return version string
Script->>Script: Extract version number (v)
alt v > 3.4
Script->>DB: Execute INSERTs for new geometric points
else v <= 3.4
Script->>DB: Execute alternative INSERTs
end
sequenceDiagram
participant Runner as GitHub Runner
participant DB as PostgreSQL Service
Runner->>DB: Start PostgreSQL service
Runner->>DB: Create database and add extension (pre-test)
Runner->>DB: Run tests for the old version
Runner->>DB: Drop and recreate database for a clean state
Runner->>DB: Run tests for the current version
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
Note 🎁 Summarized by CodeRabbit FreeYour organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.If you believe this is a mistake and have available seats, please assign one to the pull request author through the subscription management page using the link above. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
🔭 Outside diff range comments (1)
.github/workflows/update.yml (1)
130-134: 🧹 Nitpick (assertive)Confirm Validity of Extension Update Target Version
The step that updates thepgroutingextension to'3.8.0'should be double-checked to ensure that this target version is both intended and compatible with your test environment. Adding conditional checks or enhanced logging could help catch unexpected version mismatches during the upgrade process.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (10)
.github/workflows/release.yml(1 hunks).github/workflows/update-locale.yml(1 hunks).github/workflows/update.yml(3 hunks).github/workflows/website.yml(1 hunks)doc/src/sampledata.rst(1 hunks)docqueries/src/sampledata.result(3 hunks)locale/en/LC_MESSAGES/pgrouting_doc_strings.po(22 hunks)locale/pot/pgrouting_doc_strings.pot(22 hunks)sql/scripts/build-extension-update-files.pl(4 hunks)tools/testers/sampledata.sql(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (17)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: Ubuntu Boost (86)
- GitHub Check: documentation (en)
- GitHub Check: Ubuntu Boost (79)
- GitHub Check: Ubuntu Boost (78)
- GitHub Check: Ubuntu Boost (84)
- GitHub Check: Ubuntu Boost (80)
- GitHub Check: Ubuntu Boost (83)
- GitHub Check: Ubuntu Boost (56)
- GitHub Check: Ubuntu clang
- GitHub Check: Ubuntu Boost (77)
- GitHub Check: Ubuntu Boost (68)
- GitHub Check: Ubuntu Boost (76)
- GitHub Check: Ubuntu Boost (75)
- GitHub Check: macos (macos-14)
- GitHub Check: macos (macos-latest)
- GitHub Check: Check queries
🔇 Additional comments (38)
locale/pot/pgrouting_doc_strings.pot (9)
11-11: LGTM!The update to the POT-Creation-Date reflects the latest modifications to the translation template.
5413-5432: Great documentation enhancement on dead ends!The added explanation about what constitutes a dead end in a graph is thorough and helpful. It clarifies edge cases and acknowledges that interpretation depends on the application context.
5449-5452: Valuable optimization tip added!Good addition about using contraction-family functions to optimize processing when dealing with many dead ends.
5461-5464: Useful clarification on linear vertices!The explanation of when linear vertices are meaningful (speed bumps, stop signals) and the optimization tip with contraction-family functions improves the documentation.
8758-8785: Comprehensive update to pgr_degree documentation!The detailed documentation for the promoted
pgr_degreefunction includes clear definitions, edge cases, and usage examples. This aligns with its promotion from proposed to official status.
8794-8815: Good examples for pgr_degree with different signatures!The examples for both the simplified signature (Edges only) and the more complex one (Edges and Vertices) provide useful guidance for users.
8881-8896: Clear explanation of isolated vertices behavior!The documentation now explicitly states how isolated vertices are handled in the result set, which is important for users to understand.
8917-8929: Helpful additions for identifying special vertex types!The sections on finding dead ends (degree 1) and linear vertices (degree 2) provide practical use cases for the
pgr_degreefunction.
15217-15217: Clearer explanation of the Via category!The added description makes it much easier to understand what the Via category does - "find a continuous route that visits all the vertices in the order given".
doc/src/sampledata.rst (1)
244-245: Updated documentation query boundaries to match code changes.The range of queries shown in "The points of interest" section has been adjusted to reflect the new code organization in the underlying SQL files, with markers changed from
p5-p6top6-p7.tools/testers/sampledata.sql (2)
90-139: Good version-dependent implementation for pointsOfInterest data.This change elegantly addresses the PR objective about
pgr_findCloseEdgesnot always being available by implementing version-dependent code paths. For versions > 3.4, the code usespgr_findCloseEdges, while for older versions it directly inserts the data with pre-calculated values.
146-146: Updated boundary marker to align with documentation.Correctly updated the marker from
p6top7to maintain consistency with the documentation file changes.docqueries/src/sampledata.result (1)
153-202: Good version check implementation for test results.The PL/pgSQL block correctly mirrors the implementation in the main SQL file, ensuring that the test results will be consistent regardless of the pgRouting version being used.
sql/scripts/build-extension-update-files.pl (6)
225-227: Simplified version check for 3.4 update.The condition has been streamlined to only check if
$old_minor < 3.4rather than checking both major and minor versions, making the code more maintainable.
230-234: Simplified version check for 3.5 update.Similar to the 3.4 update change, this simplifies the condition to only check the minor version.
237-250: Simplified version check for 3.6 update.Consistent simplification of the version checking logic for version 3.6.
253-270: Updated version check for 3.7 update.This condition now checks that the old major version is at least 3.0 AND the minor version is less than 3.7, which is more specific and correct.
273-276: Added version check for 3.8 special cases.New condition that specifically addresses the
pgr_findcloseedgesfunction mentioned in the PR objectives, applicable when upgrading from versions between 3.4 and 3.8.
288-292: Added POD documentation markers.Added proper Perl documentation markers around the version 3.0.0 special case code, improving code documentation.
locale/en/LC_MESSAGES/pgrouting_doc_strings.po (19)
11-11: Timestamp updated correctly.The POT-Creation-Date has been updated to reflect the current date.
406-406: Documentation improvement.This addition helps set the right expectations about community feedback requirements.
3545-3545: Clear function description.The updated description for
pgr_dijkstraViaclearly communicates its purpose.
3632-3632: Mathematical notation improvement.The addition of proper mathematical notation for graph definitions improves documentation precision.
Also applies to: 3657-3657
3787-3787: Better document organization.The new section headers improve the documentation structure and organization.
Also applies to: 3950-3950
4015-4015: Important behavioral clarification.This addition helps users understand a key constraint of the flow algorithm.
4311-4314: Clear pgr_degree function description.The new description accurately explains what the function does.
4426-4429: Properly documented API change.The promotion of
pgr_degreeto official status and its new signature is clearly documented.
4432-4435: API change aligned with PR objectives.The removal of the "partial" option from
pgr_findCloseEdgesis properly documented, aligning with what was mentioned in the PR objectives about this function not always being available.
6187-6209: Comprehensive dead end documentation.This expanded explanation about dead ends provides valuable context and considerations for users.
6233-6238: Helpful implementation guidance.The suggestion about using contraction functions for many dead ends provides practical optimization advice.
10251-10286: Excellent pgr_degree function documentation.The comprehensive documentation covers all aspects of the function including:
- Definition and mathematical background
- Behavior with loops and isolated vertices
- Usage notes and "dryrun" capabilities
This thorough documentation will greatly help users understand and properly use the function.
10304-10319: Good usage examples and performance advice.The addition of practical usage examples and the recommendation to prepare vertex tables beforehand for better performance is very helpful.
10334-10337: Clear parameter documentation for different signatures.The separate explanations for the dryrun parameter with different function signatures helps prevent confusion.
10389-10419: Thorough examples for degree calculation.The detailed examples, including subgraph behavior and isolated vertices handling, will help users understand the function's behavior in different scenarios.
10433-10454: Practical application guidance.The documentation about using the function to find dead ends and linear vertices provides excellent practical application examples.
13007-13007: Fixed typo.Corrected "vaule" to "value" in the documentation.
18189-18189: Improved documentation structure.The clarification about categories within the Traversal family helps with documentation organization.
18205-18205: Clearer explanation.The rewording improves the clarity of the explanation about continuous routes.
cvvergara
force-pushed
the
ci-update-test-fix
branch
from
96315e1 to
deadf76
Compare
cvvergara
force-pushed
the
ci-update-test-fix
branch
from
63a1129 to
db51a68
Compare
2 participants
Changes proposed in this pull request:
@pgRouting/admins
Summary by CodeRabbit
pgr_degreefunction documentation with details on its parameters and results.