Skip to content

Conversation

@cvvergara
Copy link
Member

@cvvergara cvvergara commented Aug 25, 2025

Changes proposed in this pull request:

Files rename:

  • cpp_common/basePath_SSEC.hpp -> cpp_common/path.hpp
  • cpp_common/basePath_SSEC.cpp -> cpp_common/path.cpp
  • Adjusted code to file rename.

Clang-tidy:

  • fix-google-readability-braces-around-statements

While doing the fix: the static get_route with same code was in 4 files

  • Clean duplicate code
    • Rename: get_route -> get_viaRoute
    • place unique function on cpp_common/to_postgres.hpp and implementation on cpp_common/to_postgres.cpp
    • Use the new function
    • Some other enhancement were done on C/C++ code for Via functions.

@pgRouting/admins

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 25, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cvvergara cvvergara changed the title Cleaning common code Clang-tidy google-readability-braces-around-statements and other enhancements Aug 25, 2025
@cvvergara cvvergara marked this pull request as draft August 25, 2025 03:21
@cvvergara
Copy link
Member Author

ELSE
throws_ok('errorTestManyWeights',
'XX000',
'Graph Condition Failed: Graph should have atmost two distinct non-negative edge costs! If there are exactly two distinct edge costs, one of them must equal zero!',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem for update test is that I fixed spelling, atmost -> at most so for library versions before 4.0.0 spelling is still wrong.


SELECT throws_ok('errorTestManyWeights',
SELECT
CASE WHEN min_lib_version('4.0.0') THEN
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This checks for the library used

@cvvergara cvvergara marked this pull request as ready for review August 25, 2025 15:39
@cvvergara cvvergara merged commit 1894d12 into pgRouting:develop Aug 25, 2025
21 checks passed
@cvvergara cvvergara deleted the cleaning-common-code branch August 25, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants