Fixing CH7_ID_X variables

[cvvergara]

Fixes CH7_ID_X variables

• CH7_OSMID_1 -> CH7_ID_1
• CH7_OSMID_2 -> CH7_ID_2

@pgRouting/admins

Summary by CodeRabbit

• Chores
  • Updated internal build configuration variable names for consistency.

[coderabbitai]

Walkthrough

Two public-style variables in CMakeLists.txt are renamed from CH7_OSMID_1 and CH7_OSMID_2 to CH7_ID_1 and CH7_ID_2. The assigned values remain unchanged; no logic or control flow modifications.

Changes

Cohort / File(s)	Summary
Variable Renaming CMakeLists.txt	Renamed CH7_OSMID_1 to CH7_ID_1 and CH7_OSMID_2 to CH7_ID_2; RHS values preserved

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Two names take flight on the CMake stage,
CH7_OSMID bids farewell to this age,
CH7_ID steps in with simplified grace,
The values stay true, just a cosmetic embrace! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "Fixing CH7_ID_X variables" is directly related to the main changeset, which consists of renaming two CMakeLists.txt variables from CH7_OSMID_1 and CH7_OSMID_2 to CH7_ID_1 and CH7_ID_2. The title specifically mentions the variable names being changed (CH7_ID_X) and uses a clear action verb. While "fixing" could be slightly more specific as "renaming," it appropriately indicates that the variables are being updated, and a reviewer would immediately understand the scope of changes.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 46da5fd and 25dab4a.

📒 Files selected for processing (1)

• CMakeLists.txt (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: cvvergara
PR: pgRouting/workshop#255
File: CMakeLists.txt:65-70
Timestamp: 2025-09-30T18:27:06.879Z
Learning: In CMakeLists.txt for pgRouting workshop, OSM IDs (OSMID_1 through OSMID_5) are intentionally set to road/way nodes near landmarks rather than the landmark objects themselves, as they need to be part of navigable ways for routing purposes.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build

🔇 Additional comments (1)

CMakeLists.txt (1)

80-80: Variable rename is complete and consistent throughout the codebase.

Verification confirms that the rename from CH7_OSMID_1 and CH7_OSMID_2 to CH7_ID_1 and CH7_ID_2 has been properly applied across all files:

• No references to old variable names remain
• New names are used consistently in CMake configuration, SQL scripts, and documentation
• The CMakeLists.txt changes are correct and complete

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}