Enhanced pgAdmin 4 with support for Workspace layouts. #7708 #8245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshay-joshi
force-pushed
the
side_workspace
branch
2 times, most recently
from
9427e93 to
5574bad
Compare
adityatoshniwal
requested changes
Dec 10, 2024
Contributor
adityatoshniwal
left a comment
adityatoshniwal
left a comment
There was a problem hiding this comment.
Based on eyeball review.
web/pgadmin/preferences/static/js/components/PreferencesComponent.jsx
Outdated
Show resolved
Hide resolved
akshay-joshi
force-pushed
the
side_workspace
branch
2 times, most recently
from
3a8a033 to
8bc2276
Compare
Added adhoc connection support 1) Disable menu for other workspace. 2) Compare server name as well while adding the adhoc server. 3) PSQL tool should shown error if binary path is not set. Added logic to disconnect from all the servers, when layout is changed. 1) Disabled Schema Diff workspace if no tabs are present. 2) Make code generic. Fixed Demo comments. Fixed Javascript test cases Fixed feature test. Updated documentation. Fixed review comments.
akshay-joshi
force-pushed
the
side_workspace
branch
from
8bc2276 to
677b642
Compare
Contributor
Author
|
Closing this PR and will create a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.