Skip to content

Fixed an issue where Backspace, Enter, etc. input keys, when pressed, are getting written as text in the PSQL tool. #6968 #8315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akshay-joshi merged 1 commit into from
Jan 3, 2025
Merged

Fixed an issue where Backspace, Enter, etc. input keys, when pressed, are getting written as text in the PSQL tool. #6968 #8315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion web/pgadmin/tools/psql/static/js/components/PsqlComponent.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,20 @@ function psql_terminal_io(term, socket, platform, pgAdmin) {
});

term.onKey(function (ev) {
socket.emit('socket_input', {'input': ev.domEvent.key, 'key_name': ev.domEvent.code});
socket.emit('socket_input', checkInputKey(ev));
});
}

/* This function will check input key from the mentioned excludedKeys and if those
keys are pressed, it will return event's key else it will return event's domEvent key */
function checkInputKey(ev){
const excludedKeys = ['Enter', 'Escape', 'Tab', 'Backspace', 'ArrowUp', 'ArrowDown', 'ArrowLeft', 'ArrowRight'];
if(excludedKeys.includes(ev.domEvent.key)) {
return {'input': ev.key, 'key_name': ev.domEvent.code};
}
return {'input': ev.domEvent.key, 'key_name': ev.domEvent.code};
}

function psql_Addon(term) {
const fitAddon = new FitAddon();
term.loadAddon(fitAddon);
Expand Down
Loading