Provide option to open file in new tab in the the query tool.#1235 #8474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yogeshmahajan-1903
force-pushed
the
Issue_1235
branch
2 times, most recently
from
94e0167 to
f366168
Compare
akshay-joshi
requested changes
Feb 20, 2025
Contributor
akshay-joshi
left a comment
akshay-joshi
left a comment
There was a problem hiding this comment.
-
Change the title of the file select dialog to "Open File in a new tab" if 'Open in a new tab?' is selected.
-
Rename the button label "Save as" to "Save As". (Not from your PR, but just found during testing)
web/pgadmin/misc/file_manager/static/js/components/FileManager.jsx
Outdated
Show resolved
Hide resolved
web/pgadmin/tools/sqleditor/static/js/components/sections/MainToolBar.jsx
Outdated
Show resolved
Hide resolved
web/pgadmin/tools/sqleditor/static/js/components/sections/MainToolBar.jsx
Outdated
Show resolved
Hide resolved
yogeshmahajan-1903
force-pushed
the
Issue_1235
branch
from
f366168 to
716d2dd
Compare
Contributor
Author
This can be done only in server mode. We can not modify for native. Hence to keep uniform behaviour, I did not change the title.
Done. |
yogeshmahajan-1903
force-pushed
the
Issue_1235
branch
2 times, most recently
from
7238203 to
a90f864
Compare
yogeshmahajan-1903
force-pushed
the
Issue_1235
branch
from
a90f864 to
dc85e9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.