Skip to content

Fixed an issue where pgAdmin config db migration was failing on application upgrade. #9095 #9112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityatoshniwal merged 2 commits into from
Aug 28, 2025
Merged

Fixed an issue where pgAdmin config db migration was failing on application upgrade. #9095 #9112

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8525939
Fixed an issue where pgAdmin config db migration was failing on appli…
pravesh-sharma Aug 27, 2025
6cf625a
Using metadata instead of update function for upodating table.
pravesh-sharma Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions web/migrations/versions/e6ed5dac37c2_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
Create Date: 2025-07-15 12:27:48.780562

"""
import sqlalchemy as sa
from alembic import op
from sqlalchemy.orm.session import Session
from pgadmin.model import Preferences, ModulePreference, PreferenceCategory,\
Expand Down Expand Up @@ -84,15 +85,21 @@ def upgrade():
if pref.name == new_pref.name:
pref_map[pref.id] = new_pref.id

# get metadata from current connection
meta = sa.MetaData()
# define table representation
meta.reflect(op.get_bind(), only=('user_preferences',))
user_pref_table = sa.Table('user_preferences', meta)

# Update the user preferences with new preference ids
for key, val in pref_map.items():
record_to_update = session.query(UserPreference).filter_by(
pid=key).first()
if record_to_update:
record_to_update.pid = val
op.execute(
user_pref_table.update().where(
user_pref_table.c.pid == key).values(pid=val)
)

# Delete the old preferences and categories
session.query(Preferences).filter(Preferences.name.in_(prefs),
Preferences.cid.in_(category_ids)
session.query(Preferences).filter(Preferences.cid.in_(category_ids)
).delete(synchronize_session=False)

session.query(PreferenceCategory).filter(
Expand Down
Loading