Add support of DEPENDS/NO DEPENDS ON EXTENSION for ALTER FUNCTION.#6385 #9170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RohitBhati8269
force-pushed
the
GH-6385
branch
from
6be021c to
8ee71ff
Compare
anilsahoo20
reviewed
Sep 23, 2025
anilsahoo20
suggested changes
Sep 23, 2025
Contributor
anilsahoo20
left a comment
anilsahoo20
left a comment
There was a problem hiding this comment.
- Replace image for msql tab, which shows the sql for depends on extension.
- Also add extra blank line in between each alter function
anilsahoo20
reviewed
Sep 23, 2025
...ver_groups/servers/databases/schemas/functions/templates/functions/pg/sql/13_plus/create.sql
Outdated
Show resolved
Hide resolved
anilsahoo20
reviewed
Sep 23, 2025
...ver_groups/servers/databases/schemas/functions/templates/functions/pg/sql/13_plus/update.sql
Outdated
Show resolved
Hide resolved
anilsahoo20
reviewed
Sep 23, 2025
web/pgadmin/browser/server_groups/servers/databases/schemas/functions/static/js/function.ui.js
Show resolved
Hide resolved
anilsahoo20
reviewed
Sep 23, 2025
...ver_groups/servers/databases/schemas/functions/templates/functions/pg/sql/default/create.sql
Outdated
Show resolved
Hide resolved
anilsahoo20
reviewed
Sep 23, 2025
Contributor
anilsahoo20
left a comment
anilsahoo20
left a comment
There was a problem hiding this comment.
Please add Python, ReSQL and JS test cases for the new control.
RohitBhati8269
force-pushed
the
GH-6385
branch
2 times, most recently
from
018455c to
683c521
Compare
anilsahoo20
suggested changes
Sep 29, 2025
...erver_groups/servers/databases/schemas/functions/tests/pg/13_plus/alter_function_comment.sql
Outdated
Show resolved
Hide resolved
...ver_groups/servers/databases/schemas/functions/tests/ppas/13_plus/alter_function_comment.sql
Outdated
Show resolved
Hide resolved
RohitBhati8269
force-pushed
the
GH-6385
branch
from
683c521 to
97f693c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.