[pgadmin4/pgadmin4-helm] Typo indentation fix for extraEnvVars field, serverDefinitions preserved tpl. README.md typo fix, increased resources

[KorenP1]

There has been a typo in the indentation of extraEnvVars field
14 -> 12

Now preserving tpl integers and booleans in the serverDefinitions

Typo fix in the README.md, persistence.enabled supposed to be true

Increased default resources

Please repush after merging.
Thanks. Koren.

[khushboovashi]

Hi @KorenP1,

Can the version in the Chart.yaml file be automatically derived from the version.py file instead of being manually hardcoded?

[KorenP1]

Hi @khushboovashi
I dont know any way referencing the version from another file.

If you have some kind of script to upload the release it can be changed within the script.

Another option if you dont want to maintain helm versions through git, you can insert there some no meaning version for example 1.0.0 and only while releasing process, change it and push without commiting to git.

[khushboovashi]

@KorenP1, is the patch ready to review, or is it a work in progress?

[KorenP1]

@khushboovashi ready. Thanks.

[KorenP1]

@khushboovashi Thanks alot for merging the PR.
Can you please repush that helm chart to dockerhub so we all can use it before next release

[khushboovashi]

@khushboovashi Thanks alot for merging the PR. Can you please repush that helm chart to dockerhub so we all can use it before next release

We will push with every release; it is an automated process.

[KorenP1]

@khushboovashi Thanks alot for merging the PR. Can you please repush that helm chart to dockerhub so we all can use it before next release

We will push with every release; it is an automated process.

Is there an estimated time for the new release?

[khushboovashi]

@khushboovashi Thanks alot for merging the PR. Can you please repush that helm chart to dockerhub so we all can use it before next release

We will push with every release; it is an automated process.

It's scheduled on 13th Nov.

[KorenP1]

Hi @KorenP1,

Can the version in the Chart.yaml file be automatically derived from the version.py file instead of being manually hardcoded?

Hi
It is possible to pass the version within the packaging process
helm package . --version=$VERSION --app-version=$APP_VERSION
And then there is no need for changing the appVersion and version every release

[adityatoshniwal]

Hi @KorenP1,
Can the version in the Chart.yaml file be automatically derived from the version.py file instead of being manually hardcoded?

Hi It is possible to pass the version within the packaging process helm package . --version=$VERSION --app-version=$APP_VERSION And then there is no need for changing the appVersion and version every release

@KorenP1 You could create a shell file to replace version in Chart file and build package. Then simply call the shell file.

[KorenP1]

Hi @KorenP1,

Can the version in the Chart.yaml file be automatically derived from the version.py file instead of being manually hardcoded?

Hi It is possible to pass the version within the packaging process helm package . --version=$VERSION --app-version=$APP_VERSION And then there is no need for changing the appVersion and version every release

@KorenP1 You could create a shell file to replace version in Chart file and build package. Then simply call the shell file.

I think that is what we are trying to solve. Not committing versions every release.