[pgadmin4/pgadmin4-helm] Typing errors fix (appVersion, serverDefinitions)

[KorenP1]

Fixing appVersion to match with current pgadmin4 version. 9.9.0 -> 9.10.0
Fixing type error which resulted in serverDefinitions to be in YAML format and not json. #9393

Summary by CodeRabbit

• Chores
  • Updated configuration data serialization format for improved consistency and clarity in how configuration is stored and processed.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

A Helm ConfigMap template was modified to serialize server configuration data using pretty-printed JSON instead of YAML, and template whitespace trimming was adjusted.

Changes

Cohort / File(s)	Summary
Helm ConfigMap template pkg/helm/templates/configmap-serverDefinitions.yaml	Changed servers.json serialization from toYaml to toPrettyJson for improved JSON formatting in ConfigMap; adjusted template end directive whitespace handling

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title mentions 'Typing errors fix' but the raw summary indicates the main change is replacing YAML serialization with JSON format in ConfigMap, which is a functional fix, not a 'typing error' in the traditional sense.	Consider revising the title to more accurately describe the actual change, such as 'Fix serverDefinitions JSON serialization in ConfigMap' or 'Correct serverDefinitions format from YAML to JSON'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8c153be and de5b532.

📒 Files selected for processing (1)

• pkg/helm/templates/configmap-serverDefinitions.yaml (1 hunks)

⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: run-feature-tests-pg (16)
• GitHub Check: run-feature-tests-pg (13)
• GitHub Check: run-feature-tests-pg (14)
• GitHub Check: run-feature-tests-pg (15)
• GitHub Check: run-feature-tests-pg (17)
• GitHub Check: run-feature-tests-pg (18)

🔇 Additional comments (1)

pkg/helm/templates/configmap-serverDefinitions.yaml (1)

15-16: The script execution encountered sandbox limitations—helm and yq aren't available, so the "JSON is valid" output is a false positive. Let me verify the toPrettyJson function through documentation instead.

Fix for serverDefinitions JSON serialization is correct.

The toPrettyJson function encodes an item into a pretty (indented) JSON string. The change from YAML to JSON serialization using toPrettyJson directly addresses issue #9393. The | ... | nindent 4 pattern properly formats the JSON with correct indentation for the YAML literal block scalar.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[KorenP1]

@egvimo @khushboovashi
PR fix
Thanks for informing.