Skip to content

Conversation

@hausertt
Copy link
Contributor

@hausertt hausertt commented Dec 1, 2025

Fixes Issue #9408 .

Summary by CodeRabbit

  • Chores

    • Helm chart version updated to 9.10.1
  • Bug Fixes

    • Corrected the deployment template's handling of extra volume mounts configuration to ensure proper reference to the correct configuration values.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 1, 2025

Walkthrough

The Helm chart version is bumped to 9.10.1, and the deployment template is updated to use .Values.extraVolumeMounts instead of .Values.extraVolumes as the source for conditional injection of extra container volume mounts.

Changes

Cohort / File(s) Summary
Helm Chart Updates
pkg/helm/Chart.yaml, pkg/helm/templates/deployment.yaml
Version bumped from 9.10.0 to 9.10.1; deployment template corrects the conditional source for extra volume mounts from extraVolumes to extraVolumeMounts to ensure proper mounting of volumes in container spec.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify that extraVolumeMounts is the correct field name in the Values schema to ensure this template fix resolves the intended behavior.
  • Confirm the version bump aligns with semantic versioning practices for this patch-level change.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: replacing .Values.extraVolumes with .Values.extraVolumeMounts in the deployment template, which aligns with the primary modification in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 70e4435 and 13b8748.

📒 Files selected for processing (2)
  • pkg/helm/Chart.yaml (1 hunks)
  • pkg/helm/templates/deployment.yaml (1 hunks)
🔇 Additional comments (2)
pkg/helm/Chart.yaml (1)

3-3: Version bump is appropriate for the bug fix.

Incrementing the patch version from 9.10.0 to 9.10.1 aligns with semantic versioning for a bug fix release.

pkg/helm/templates/deployment.yaml (1)

157-159: Fix addresses the correct semantic issue in volumeMounts injection.

The change from .Values.extraVolumes to .Values.extraVolumeMounts in the volumeMounts section is the correct fix. The template now allows users to inject additional volume mounts via the appropriate values key, while the volumes section (lines 86–88) correctly continues to reference .Values.extraVolumes for volume definitions. The indentation is consistent with adjacent volumeMount entries.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@khushboovashi
Copy link
Contributor

@KorenP1, can you please review this one?

@KorenP1
Copy link
Contributor

KorenP1 commented Dec 1, 2025

@KorenP1, can you please review this one?

Great fix, probably a typo on my side.
Added a comment about changing the version.

Copy link

@edvic-rolGG-86 edvic-rolGG-86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@

@khushboovashi
Copy link
Contributor

@KorenP1, can you please review this one?

Great fix, probably a typo on my side. Added a comment about changing the version.

Have you requested changes in PR?

@hausertt
Copy link
Contributor Author

hausertt commented Dec 2, 2025

Happy to adjust the pr if needed. But didn't see any specific request to change something.

@KorenP1
Copy link
Contributor

KorenP1 commented Dec 2, 2025

Yes, there is no need for version change in the Chart.yaml

@KorenP1
Copy link
Contributor

KorenP1 commented Dec 2, 2025

Great

@khushboovashi khushboovashi merged commit 2ef67a5 into pgadmin-org:master Dec 3, 2025
34 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants