Add a new button in the query tool data output toolbar to get entire …

[adityatoshniwal]

…range of data. #8890

Summary by CodeRabbit

• New Features

  • Added a "Show entire range" button in the query tool to retrieve and display the complete result set; pagination inputs now only appear when appropriate.

• Documentation

  • Updated release notes formatting.

• Chores

  • Cleaned up Italian translations, removing many obsolete entries which may cause fallbacks to source strings.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Adds a "Show entire range" control to the query tool results toolbar and updates pagination to emit FETCH_WINDOW(from,to); adjusts a CodeMirror test helper to use cmTile; updates release notes; removes many Italian translation entries.

Changes

Cohort / File(s)	Change Summary
Release Notes docs/en_US/release_notes_9_12.rst	Added a release-note entry for Issue #8890 (new "Show entire range" button) and reformatted an existing bug-fix line.
Query tool UI web/pgadmin/tools/sqleditor/static/js/components/sections/ResultSetToolbar.jsx	Imported AllInboxRoundedIcon; added a "Show entire range" button; moved pagination inputs under a serverCursor conditional; introduced fetchWindow(from,to) helper and updated callers to emit FETCH_WINDOW(from,to) (removed direct serverCursor arg).
Test utility web/regression/feature_utils/pgadmin_page.py	Replaced arguments[0].cmView.view usages with arguments[0].cmTile.view for setValue and setCursor in CodeMirror population path.
Translations (Italian) web/pgadmin/translations/it/LC_MESSAGES/messages.po	Removed a large set of Italian msgid/msgstr entries across UI labels, prompts, error messages, and other strings (reduced translated entries).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

• Inspect ResultSetToolbar.jsx for correct conditional rendering and side effects when switching to "Show entire range".
• Verify event payload change: consumers of FETCH_WINDOW accept the new (from,to) signature.
• Run or review regression tests that use pgadmin_page.py to confirm cmTile access works in all test environments.
• Spot-check removed messages.po entries to ensure deletions are intentional and won't cause missing translations in critical UI paths.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main objective: adding a new button to the query tool data output toolbar to fetch the entire range of data, matching the PR description and primary code changes.

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7c5b16f and dd818dc.

📒 Files selected for processing (4)

• docs/en_US/release_notes_9_12.rst (1 hunks)
• web/pgadmin/tools/sqleditor/static/js/components/sections/ResultSetToolbar.jsx (4 hunks)
• web/pgadmin/translations/it/LC_MESSAGES/messages.po (0 hunks)
• web/regression/feature_utils/pgadmin_page.py (1 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 63397a0 and 343fcfe.

📒 Files selected for processing (3)

• docs/en_US/release_notes_9_12.rst (1 hunks)
• web/pgadmin/tools/sqleditor/static/js/components/sections/ResultSetToolbar.jsx (3 hunks)
• web/regression/feature_utils/pgadmin_page.py (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

web/pgadmin/tools/sqleditor/static/js/components/sections/ResultSetToolbar.jsx (2)

web/pgadmin/tools/sqleditor/static/js/components/sections/ResultSet.jsx (1)

• eventBus (831-831)

web/pgadmin/tools/sqleditor/static/js/components/QueryToolConstants.js (2)

• QUERY_TOOL_EVENTS (12-86)
• QUERY_TOOL_EVENTS (12-86)

⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)

• GitHub Check: run-python-tests-pg (windows-latest, 18)
• GitHub Check: run-python-tests-pg (windows-latest, 16)
• GitHub Check: run-python-tests-pg (windows-latest, 15)
• GitHub Check: run-python-tests-pg (windows-latest, 14)
• GitHub Check: run-feature-tests-pg (17)
• GitHub Check: run-python-tests-pg (windows-latest, 13)
• GitHub Check: run-feature-tests-pg (18)
• GitHub Check: run-feature-tests-pg (14)
• GitHub Check: run-feature-tests-pg (16)
• GitHub Check: run-feature-tests-pg (15)
• GitHub Check: run-feature-tests-pg (13)

🔇 Additional comments (4)

web/pgadmin/tools/sqleditor/static/js/components/sections/ResultSetToolbar.jsx (3)

208-249: LGTM! Well-implemented "Show entire range" feature.

The new UI controls for showing the entire data range are well-structured:

• Properly gated behind !serverCursor condition
• The "Show entire range" button correctly updates inputs and triggers the fetch
• Appropriate disabled state when already showing the full range
• Maintains consistency with existing pagination controls

---

27-27: LGTM! Icon import added correctly.

The AllInboxRoundedIcon import is properly added and used in the new "Show entire range" button.

---

121-121: [Rewritten review comment]
[Classification tag]

web/regression/feature_utils/pgadmin_page.py (1)

965-967: Verify if cmTile.view is the correct property path for accessing CodeMirror.

The change from arguments[0].cmView to arguments[0].cmTile.view needs verification to ensure it matches the actual CodeMirror initialization in the application. Confirm that:

• The CodeMirror instance is properly initialized with a cmTile property containing a view object
• The setValue() and setCursor() methods exist on this property
• No other CodeMirror API changes have broken this test utility

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 343fcfe and 7c5b16f.

📒 Files selected for processing (4)

• docs/en_US/release_notes_9_12.rst (1 hunks)
• web/pgadmin/tools/sqleditor/static/js/components/sections/ResultSetToolbar.jsx (3 hunks)
• web/pgadmin/translations/it/LC_MESSAGES/messages.po (0 hunks)
• web/regression/feature_utils/pgadmin_page.py (1 hunks)

💤 Files with no reviewable changes (1)

• web/pgadmin/translations/it/LC_MESSAGES/messages.po

🚧 Files skipped from review as they are similar to previous changes (2)

• web/regression/feature_utils/pgadmin_page.py
• docs/en_US/release_notes_9_12.rst

🧰 Additional context used

🧬 Code graph analysis (1)

web/pgadmin/tools/sqleditor/static/js/components/sections/ResultSetToolbar.jsx (2)

web/pgadmin/tools/sqleditor/static/js/components/sections/ResultSet.jsx (1)

• eventBus (831-831)

web/pgadmin/tools/sqleditor/static/js/components/QueryToolConstants.js (2)

• QUERY_TOOL_EVENTS (12-86)
• QUERY_TOOL_EVENTS (12-86)

⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: run-feature-tests-pg (16)
• GitHub Check: run-feature-tests-pg (15)
• GitHub Check: run-feature-tests-pg (14)
• GitHub Check: run-feature-tests-pg (18)
• GitHub Check: run-feature-tests-pg (17)
• GitHub Check: run-feature-tests-pg (13)

🔇 Additional comments (2)

web/pgadmin/tools/sqleditor/static/js/components/sections/ResultSetToolbar.jsx (2)

27-27: Icon import looks fine; please ensure it’s included in translations/build footprint expectations.
No functional concerns with adding AllInboxRoundedIcon here.

---

118-123: FETCH_WINDOW event signature mismatch: callback parameter never supplied.

The fireEvent(QUERY_TOOL_EVENTS.FETCH_WINDOW, from, to) calls (lines 121, 132, 212, 229) emit only 2 arguments, but fetchWindow() in ResultSet.jsx expects 3 parameters: (fromRownum, toRownum, callback). The callback is invoked with callback?.() but will always be undefined since no emit site supplies it. All fireEvent calls are internally consistent with each other, but this signature mismatch indicates the callback functionality was lost when this feature was added (commit 7c5b16f). Verify whether the callback parameter should be removed from fetchWindow() or whether callbacks need to be re-supplied by emit sites.