Update Windows code signing to work with new hardware key (or none)

[dpage]

Summary by CodeRabbit

• Chores
  • Made Windows code signing optional and conditional in the build process. When credentials are configured, executables and installers are signed with enhanced security parameters; otherwise, signing is skipped with messaging indicating status throughout the build pipeline.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The Make.bat script is modified to implement optional code signing controlled by a PGADMIN_WINDOWS_CSC environment variable. When empty, all signing operations are skipped with messaging; when set, conditional signing is performed at multiple stages (pgAdmin4.exe, installer binary, installer creation, and verification) with enhanced signtool parameters.

Changes

Cohort / File(s)

Summary

Conditional code signing implementation Make.bat

Added environment variable PGADMIN_WINDOWS_CSC initialization (empty by default). Wrapped signing operations for pgAdmin4.exe binary and installer with conditional checks. Updated signtool invocations with expanded parameters including certificate name, timestamping, and cryptographic hash settings when signing is enabled. Modified installer creation flow to conditionally pass signing parameters to Inno Setup. Enhanced signature verification to skip when signing is disabled. Added user-facing messages at environment validation, post-signing, and verification stages to indicate whether signing is active or disabled.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4443494 and 33aa2ff.

📒 Files selected for processing (1)

• Make.bat

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}