Skip to content

Fixed an issue where connection parameters were using localized values instead of literal values, causing connection failures. #9500 #9517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akshay-joshi merged 2 commits into from
Jan 8, 2026
Merged

Fixed an issue where connection parameters were using localized values instead of literal values, causing connection failures. #9500 #9517

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24b2b9f
Fixed an issue where connection parameters were using localized value…
pravesh-sharma Jan 7, 2026
3232582
Implememted review comments.
pravesh-sharma Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 11 additions & 15 deletions web/pgadmin/browser/server_groups/servers/static/js/server.ui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export function getConnectionParameters() {
'value': 'passfile', 'label': gettext('Password file'), 'vartype': 'file'
}, {
'value': 'channel_binding', 'label': gettext('Channel binding'), 'vartype': 'enum',
'enumvals': [gettext('prefer'), gettext('require'), gettext('disable')],
'enumvals': ['prefer', 'require', 'disable'],
'min_server_version': '13'
}, {
'value': 'connect_timeout', 'label': gettext('Connection timeout (seconds)'), 'vartype': 'integer'
Expand Down Expand Up @@ -82,16 +82,15 @@ export function getConnectionParameters() {
'max_server_version': '13'
}, {
'value': 'replication', 'label': gettext('Replication'), 'vartype': 'enum',
'enumvals': [gettext('on'), gettext('off'), gettext('database')],
'enumvals': ['on', 'off', 'database'],
'min_server_version': '11'
}, {
'value': 'gssencmode', 'label': gettext('GSS encmode'), 'vartype': 'enum',
'enumvals': [gettext('prefer'), gettext('require'), gettext('disable')],
'enumvals': ['prefer', 'require', 'disable'],
'min_server_version': '12'
}, {
'value': 'sslmode', 'label': gettext('SSL mode'), 'vartype': 'enum',
'enumvals': [gettext('allow'), gettext('prefer'), gettext('require'),
gettext('disable'), gettext('verify-ca'), gettext('verify-full')]
'enumvals': ['allow', 'prefer', 'require', 'disable', 'verify-ca', 'verify-full']
}, {
'value': 'sslcompression', 'label': gettext('SSL compression?'), 'vartype': 'bool',
}, {
Expand All @@ -116,26 +115,23 @@ export function getConnectionParameters() {
}, {
'value': 'ssl_min_protocol_version', 'label': gettext('SSL min protocol version'),
'vartype': 'enum', 'min_server_version': '13',
'enumvals': [gettext('TLSv1'), gettext('TLSv1.1'), gettext('TLSv1.2'),
gettext('TLSv1.3')]
'enumvals': ['TLSv1', 'TLSv1.1', 'TLSv1.2', 'TLSv1.3']
}, {
'value': 'ssl_max_protocol_version', 'label': gettext('SSL max protocol version'),
'vartype': 'enum', 'min_server_version': '13',
'enumvals': [gettext('TLSv1'), gettext('TLSv1.1'), gettext('TLSv1.2'),
gettext('TLSv1.3')]
'enumvals': ['TLSv1', 'TLSv1.1', 'TLSv1.2', 'TLSv1.3']
}, {
'value': 'krbsrvname', 'label': gettext('Kerberos service name'), 'vartype': 'string',
}, {
'value': 'gsslib', 'label': gettext('GSS library'), 'vartype': 'string',
}, {
'value': 'target_session_attrs', 'label': gettext('Target session attribute'),
'vartype': 'enum',
'enumvals': [gettext('any'), gettext('read-write'), gettext('read-only'),
gettext('primary'), gettext('standby'), gettext('prefer-standby')]
'enumvals': ['any', 'read-write', 'read-only', 'primary', 'standby', 'prefer-standby']
}, {
'value': 'load_balance_hosts', 'label': gettext('Load balance hosts'),
'vartype': 'enum', 'min_server_version': '16',
'enumvals': [gettext('disable'), gettext('random')]
'enumvals': ['disable', 'random']
}, {
'value': 'gssdelegation', 'label': gettext('GSS delegation?'), 'vartype': 'bool',
'min_server_version': '16'
Expand All @@ -144,19 +140,19 @@ export function getConnectionParameters() {
'min_server_version': '16'
}, {
'value': 'sslnegotiation', 'label': gettext('SSL negotiation'),
'vartype': 'enum', 'enumvals': [gettext('postgres'), gettext('direct')],
'vartype': 'enum', 'enumvals': ['postgres', 'direct'],
'min_server_version': '17'
}, {
'value': 'sslkeylogfile', 'label': gettext('SSL Key Logfile'), 'vartype': 'file',
'min_server_version': '18'
}, {
'value': 'min_protocol_version', 'label': gettext('Min protocol version'),
'vartype': 'enum', 'min_server_version': '18',
'enumvals': [gettext('3.0'), gettext('3.2'), gettext('latest')]
'enumvals': ['3.0', '3.2', 'latest']
}, {
'value': 'max_protocol_version', 'label': gettext('Max protocol version'),
'vartype': 'enum', 'min_server_version': '18',
'enumvals': [gettext('3.0'), gettext('3.2'), gettext('latest')]
'enumvals': ['3.0', '3.2', 'latest']
}, {
'value': 'oauth_issuer', 'label': gettext('OAuth issuer'), 'vartype': 'string',
'min_server_version': '18'
Expand Down
Loading