Support null_test and boolean_test node type with parsing#335
Merged
Conversation
When the query like SELECT col1 FROM t1 WHERE ((SELECT col2 FROM t2 LIMIT 1) IS NULL) is passed, the subselect_items contain the item with the null_test node type. This null_test node type could contain a table name or a function potentially, but that node type is ignored currently, therefore these table names or functions weren't properly extracted as tables/functions of the query. With this change, by adding the argument of null_test node to the subselect_items list, the arg will be evaluated again later on and will be properly handled.
msakrejda
approved these changes
Jun 6, 2025
Contributor
Author
|
Sean pointed out that we try to keep the Ruby and Rust versions in sync, and when I took a Rust version, I noticed that Rust has the code for boolean_test too, which wasn't supported in Ruby version yet. |
keiko713
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the query like
SELECT col1 FROM t1 WHERE ((SELECT col2 FROM t2 LIMIT 1) IS NULL)is passed, the subselect_items contain the item with the null_test node type.This null_test node type could contain a table name or a function potentially, but that node type is ignored currently, therefore these table names or functions weren't properly extracted as tables/functions of the query.
With this change, by adding the argument of null_test node to the subselect_items list, the arg will be evaluated again later on and will be properly handled.