fix: bind setTimeout to globalThis in SupabaseBroadcastAdapter for browser compatibility #402
+479
−82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Fix setTimeout context binding issue in SupabaseBroadcastAdapter
This PR fixes a browser compatibility issue in the
SupabaseBroadcastAdapterclass wheresetTimeoutwas losing its context binding when used in browser environments. The issue would cause an error:"'setTimeout' called on an object that does not implement interface Window".The fix:
setTimeoutto the global context usingsetTimeout.bind(globalThis)in the constructorThis issue only manifested in browser environments, not in Node.js, which explains why our existing tests didn't catch it. I've added a test that simulates the browser's strict context requirements for
setTimeout.The PR also includes a planning document for implementing browser-based testing to catch similar issues in the future.