Skip to content

Commit 32b09c0

Browse files
committed
Fixed indices and values methods returning tuple instead of list in certain cases [skip ci]
1 parent 8a621a3 commit 32b09c0

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

pgvector/utils/sparsevec.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,7 @@ def from_binary(cls, value):
108108
dim, nnz, unused = unpack_from('>iii', value)
109109
indices = unpack_from(f'>{nnz}i', value, 12)
110110
values = unpack_from(f'>{nnz}f', value, 12 + nnz * 4)
111-
# TODO convert indices and values to lists in 0.4.0
112-
return cls._from_parts(int(dim), indices, values)
111+
return cls._from_parts(int(dim), list(indices), list(values))
113112

114113
@classmethod
115114
def _from_parts(cls, dim, indices, values):

tests/test_psycopg.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -111,9 +111,8 @@ def test_sparsevec_binary_format(self):
111111
embedding = SparseVector([1.5, 0, 2, 0, 3, 0])
112112
res = conn.execute('SELECT %b::sparsevec', (embedding,), binary=True).fetchone()[0]
113113
assert res.dimensions() == 6
114-
# TODO convert indices and values to lists in 0.4.0
115-
assert res.indices() == (0, 2, 4)
116-
assert res.values() == (1.5, 2, 3)
114+
assert res.indices() == [0, 2, 4]
115+
assert res.values() == [1.5, 2, 3]
117116
assert res.to_list() == [1.5, 0, 2, 0, 3, 0]
118117
assert np.array_equal(res.to_numpy(), np.array([1.5, 0, 2, 0, 3, 0]))
119118

0 commit comments

Comments
 (0)