Resolving Issue With Named Parameters and Dispatcher

[Fenikkusu]

Hello!

• Type: bug fix
• Link to issue: N/A

In raising this pull request, I confirm the following:

• I have read and understood the Contributing Guidelines
• I have checked that another pull request for this purpose does not exist
• I wrote some tests for this PR
• I have updated the relevant CHANGELOG
• I have created a PR for the documentation about this change

Small description of change:

Since PHP 8.0, call_user_func_array now uses arrays with non-numeric keys as named parameters. If you have an action that does not use/define properties, this causes the error Unknown named parameter. While this can be avoided by adding the parameters, this change fixes it so this is no longer an issue. It also adds in the ability to hook into an event for the calling of the handler, though that was originally just confirmation of the bug. Just making the change to call array_values is enough otherwise.

Thanks

[niden]

@Fenikkusu I will look at this a bit later on. Can you please rebase to target the 5.0.0 branch? We don't merge to master other than releases.

Thanks

[Fenikkusu]

@Fenikkusu I will look at this a bit later on. Can you please rebase to target the 5.0.0 branch? We don't merge to master other than releases.

Thanks

I was wondering about that. Since it was 5.8.0, I didn't see a compatible branch, hence I went with master. I've updated it to 5.0.x.

[Fenikkusu]

...And Now I've got to do a full rebase...fudge...

[niden]

@Fenikkusu don't worry about the PHP 8.4 build failing (from PECL). That is what we are working on now.

[niden]

I mean leave the header files as they are. If your PR only fails on PHP 8.4 build then it is good enough.

[Fenikkusu]

I mean leave the header files as they are. If your PR only fails on PHP 8.4 build then it is good enough.

I've reverted them out. I get anal about making sure all the testing is passing.

[Fenikkusu]

• Cleaned & Squashed Commits
• Added Testing For No Params, With Named Params, and Events
• Updated Change Log

Side Thought: I normally use Route Converters to Convert IDs to Models. One downside of doing it this way is that you cannot throw proper errors and have them redirected as you can with traditional dispatcher events. In theory, someone could use the new events to do this instead of using Converters.

[niden]

Thank you @Fenikkusu