-
Notifications
You must be signed in to change notification settings - Fork 0
Fix various parser gaps #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rlerdorf
commented
Oct 22, 2025
- Asymmetric Visibility: add public(set)
- Added PublicSetKeyword token
- Updated PropertyDeclaration node to include setVisibilityToken field
- Parser now extracts and handles asymmetric visibility modifiers in properties
- Added test case: asymmetric-visibility-public-set.php
- New Without Parentheses with Chaining
- Enhanced new expression parsing to support chaining (->?, [], (), ::) directly after new without parentheses
- Unterminated Comment Detection
- Added detection for unterminated /* or /** comments at end of file
- New unterminatedCommentDiagnostic field on SourceFileNode
- Fixed DiagnosticsProvider to check root node diagnostics
- Invalid Syntax Error Recovery
- Parse enum cases in classes (invalid but accepted for better error recovery)
- Parse trait use in interfaces (invalid but accepted for error recovery)
- Detect invalid ?Type|OtherType syntax (nullable with union types) and mark as error
- Abstract Property Hooks
- Added support for abstract/interface property hooks with just semicolon
- Legacy Type Aliases
- Added support for legacy type keywords for better error recovery: boolean, integer, double, real, binary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |