-
Notifications
You must be signed in to change notification settings - Fork 0
Mirror upstream elastic/elasticsearch#134118 for AI review (snapshot of HEAD tree) #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BASE=3eefef7fd007602714ba786e20d58847ec9b1561 HEAD=35b2a6eb6099dae4c3480474460ebb8a1a9d01f7 Branch=main
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (3)
.buildkite/pipelines/java-ea-check-new-build.yml
(1 hunks).buildkite/scripts/trigger-if-java-ea-new-build.sh
(1 hunks)catalog-info.yaml
(1 hunks)
🧰 Additional context used
🪛 Shellcheck (0.11.0)
.buildkite/scripts/trigger-if-java-ea-new-build.sh
[error] 10-10: The shebang must be on the first line. Delete blanks and move comments.
(SC1128)
[warning] 55-55: jdkbuild appears unused. Verify use (or export if used externally).
(SC2034)
[warning] 56-56: jdk_timestamp appears unused. Verify use (or export if used externally).
(SC2034)
# | ||
# Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
# or more contributor license agreements. Licensed under the "Elastic License | ||
# 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side | ||
# Public License v 1"; you may not use this file except in compliance with, at | ||
# your election, the "Elastic License 2.0", the "GNU Affero General Public | ||
# License v3.0 only", or the "Server Side Public License, v 1". | ||
# | ||
|
||
#!/bin/bash | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the shebang to the very first line.
With the license block sitting above #!/bin/bash
, the kernel ignores the shebang when the file is executed directly, so Buildkite will run the script under /bin/sh
. The script relies on bash-specific features ([[ … ]]
, arithmetic expansion, etc.), so it will break. Put the shebang on Line 1 and keep the license comment immediately after it.
-#
-# Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
-# or more contributor license agreements. Licensed under the "Elastic License
-# 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side
-# Public License v 1"; you may not use this file except in compliance with, at
-# your election, the "Elastic License 2.0", the "GNU Affero General Public
-# License v3.0 only", or the "Server Side Public License, v 1".
-#
-
-#!/bin/bash
+#!/bin/bash
+#
+# Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+# or more contributor license agreements. Licensed under the "Elastic License
+# 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side
+# Public License v 1"; you may not use this file except in compliance with, at
+# your election, the "Elastic License 2.0", the "GNU Affero General Public
+# License v3.0 only", or the "Server Side Public License, v 1".
+#
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
# | |
# Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | |
# or more contributor license agreements. Licensed under the "Elastic License | |
# 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side | |
# Public License v 1"; you may not use this file except in compliance with, at | |
# your election, the "Elastic License 2.0", the "GNU Affero General Public | |
# License v3.0 only", or the "Server Side Public License, v 1". | |
# | |
#!/bin/bash | |
#!/bin/bash | |
# | |
# Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | |
# or more contributor license agreements. Licensed under the "Elastic License | |
# 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side | |
# Public License v 1"; you may not use this file except in compliance with, at | |
# your election, the "Elastic License 2.0", the "GNU Affero General Public | |
# License v3.0 only", or the "Server Side Public License, v 1". | |
# |
🧰 Tools
🪛 Shellcheck (0.11.0)
[error] 10-10: The shebang must be on the first line. Delete blanks and move comments.
(SC1128)
🤖 Prompt for AI Agents
.buildkite/scripts/trigger-if-java-ea-new-build.sh lines 1-11: the shebang is
currently after the license block so the kernel ignores it and the script may
run under /bin/sh; move the line "#!/bin/bash" to be the very first line of the
file and leave the license comment immediately following it, ensuring the script
is executed with bash and preserving the license text unchanged.
Single commit with tree=35b2a6eb6099dae4c3480474460ebb8a1a9d01f7^{tree}, parent=3eefef7fd007602714ba786e20d58847ec9b1561. Exact snapshot of upstream PR head. No conflict resolution attempted.
Summary by CodeRabbit