Mirror upstream elastic/elasticsearch#135212 for AI review (snapshot of HEAD tree) #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BASE=e89c613dc36998037d5915f79c1cc92e9c249e76 HEAD=d2b174cfb1581cc6bf445eee1962a2a8a9918cb4 Branch=main
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables the
index.dimensionstsid creation optimization If dynamic templates are used to define dimensions.There are edge cases that would lead us to include more fields into the tsid than we should (see code comments and tests).
While there may be ways we could try to only fall back in these problematic cases, it seems better to just always fall back in dynamic templates that define dimensions are involved. Otherwise, it'll be very hard to explain and debug this. For OTel metrics, we're not using dynamic templates to define dimensions, only passthrough fields.
Addresses elastic#132566 (comment)