Mirror upstream elastic/elasticsearch#134851 for AI review (snapshot of HEAD tree) #202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_typeisn't special in ingest conditional scripts anymore, and we shouldn't warn about it as if it is.With this pipeline:
This
_simulatecall:gives this result on
main:The result would be the same after this PR, there just wouldn't be a warning anymore -- that is,
_typeis just a regular old non-special field, like_fooor_baror whatever (edit: that is, at least in terms of reads).Related to elastic#134816, in that I'm pulling a part of that out as its own PR for searchability and accounting purposes.