Mirror upstream elastic/elasticsearch#133831 for AI review (snapshot of HEAD tree) #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BASE=208cd45f284f818f022e09ba281b0d18de540f36 HEAD=c6f020ba75b19ae51e4dbab8ed0cd07bc866ccfa Branch=main
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Roles page is duplicated and exists in both the Deploy and manage and the Reference sections. The content is starting to drift, so I'm editing the page in the Reference section to reconcile the information.
Refers to #2738
Details:
kibana_userrole is deprecated, so I added theapplies_totag. I can't find info on when it was deprecated only that it is deprecated.kibana_dashboard_only_useris deprecated, so I added theapplies_totag. I can't find info on when it is deprecated (strange I can find no mention of this role in the Kibana repo).reporting_userroles is marked as deprecated here but wasn't marked as such on the Roles page in the Reference section, so I've updated that.