generated from pharmaverse/admiraltemplate
-
Notifications
You must be signed in to change notification settings - Fork 12
Closes #221: Feature request - Provide CSV files #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Gero1999
wants to merge
13
commits into
main
Choose a base branch
from
221-feature-request-provide-csv-files
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9c12f0c
add CSV generation in create_sdtms_data.R (inst/extdata folder)
Gero1999 92ee61f
add in .Rbuildignore CSV files
Gero1999 52375b3
bump pkg dev version & add news in documentation
Gero1999 dec79f1
readme: add CSV info for data & how-to-update sections
Gero1999 d3d2aa6
Update NEWS.md
Gero1999 d9cd254
Update README.md
Gero1999 4e1dbc0
readme: change links to https paths
Gero1999 f1bc35e
rm interactive data exploration (change from different branch)
Gero1999 ea90f97
spelling: update wordlist
Gero1999 88f53a7
Apply suggestions from code review Lina2689
Gero1999 f2b7cc6
change NEWS.md: extdata/sdtm-csv/ > inst/extdata
Gero1999 a4b1c42
Merge accept incoming or both changes
Gero1999 e1cef5c
bump version to 1.4.0.9002
Gero1999 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,7 @@ | ||
| # pharmaversesdtm <img src="man/figures/logo.png" align="right" width="200" style="margin-left:50px;" alt="pharmaverse sdtm hex"/> | ||
|
|
||
| > <sup>Interactive data exploration: <a href="https://pharmaverse.github.io/pharmaversesdtm/articles/preview-sdtm.html">Preview SDTM vignette</a></sup> | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this be part of this PR? @Lina2689
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. good catch, that is my bad I'll remove it later |
||
|
|
||
| <!-- badges: start --> | ||
|
|
||
| [](https://pharmaverse.org) | ||
|
|
@@ -11,7 +13,7 @@ Test data (SDTM) for the pharmaverse family of packages | |
|
|
||
| - [Purpose](#purpose) | ||
| - [Installation](#installation) | ||
| - [Data Sources](#data-sources) | ||
| - [Data](#data) | ||
| - [Naming Conventions](#naming) | ||
| - [How To Update](#how-to-update) | ||
|
|
||
|
|
@@ -31,10 +33,17 @@ if (!requireNamespace("remotes", quietly = TRUE)) { | |
| remotes::install_github("pharmaverse/pharmaversesdtm", ref = "main") # This command installs the latest development version directly from GitHub. | ||
| ``` | ||
|
|
||
| ## Data Sources {#data-sources} | ||
|
|
||
| ## Data {#data} | ||
|
|
||
| ### Data Sources | ||
|
|
||
| Some test datasets have been sourced from the [CDISC pilot project](https://github.com/cdisc-org/sdtm-adam-pilot-project), while other datasets have been constructed ad-hoc by the {admiral} team. Please check the [Reference page](https://pharmaverse.github.io/pharmaversesdtm/reference/index.html) for detailed information regarding the source of specific datasets. | ||
|
|
||
| ### Data Formats | ||
|
|
||
| Each dataset is provided in both RDA and CSV formats. The `.rda` files are used within the R package and saved in the repository [here](data/). The `.csv` files are saved [here](inst/extdata/). | ||
Gero1999 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| ## Naming Conventions {#naming} | ||
|
|
||
| - Datasets that are TA-agnostic: same as SDTM domain name (e.g., `dm`, `rs`). | ||
|
|
@@ -78,7 +87,7 @@ This metadata drives the automated documentation process, and the file is read b | |
|
|
||
| ### Adding New SDTM Datasets | ||
|
|
||
| - Create a program in the `data-raw/` folder, named `<name>.R`, where `<name>` should follow the [naming convention](#naming), to generate the test data and output `<name>.rda` to the `data/` folder. | ||
| - Create a program in the `data-raw/` folder, named `<name>.R`, where `<name>` should follow the [naming convention](#naming), to generate the test data and output `<name>.rda` to the `data/` folder, as well as `<name>.csv` to the `inst/extdata` folder. | ||
Gero1999 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - Use CDISC pilot data such as `dm` as input in this program in order to create realistic synthetic data that remains consistent with other domains (not mandatory). | ||
| - Note that **no personal data should be used** as part of this package, even if anonymized. | ||
| - Run the program. | ||
|
|
@@ -97,7 +106,7 @@ This metadata drives the automated documentation process, and the file is read b | |
| - Modifying the dataset purpose or structure. | ||
| - Updating the dataset therapeutic area. | ||
| - Removing a dataset (delete its entry from the JSON entirely). | ||
| - Run the program, and output updated `<name>.rda` to the `data/` folder. | ||
| - Run the program, and output updated `<name>.rda` to the `data/` folder, as well as `<name>.csv` to the `inst/extdata` folder. | ||
Gero1999 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - Run `data-raw/create_sdtms_data.R` in order to update `NAMESPACE` and update the `.Rd` files in `man/`. | ||
| - Add your GitHub handle to `.github/CODEOWNERS`. | ||
| - Update `NEWS.md`. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the folder path, you are saving the csv files under
inst/extdataand here the its mentioned underextdata/sdtm-csv/.